Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPM is out of date - needs a publish #250

Closed
Ratismal opened this issue Mar 14, 2017 · 9 comments
Closed

NPM is out of date - needs a publish #250

Ratismal opened this issue Mar 14, 2017 · 9 comments

Comments

@Ratismal
Copy link

Salutations,

As the subject says, the latest build available on NPM is out of date. The convolution matrix functionality that was added 4 months ago is not available when installing from npm, I'm not sure about any other discrepency. Please increment the version number and publish so I don't have to do a git install every time. Thanks!

@Ratismal
Copy link
Author

This has also been mention in #237

@smolnikov
Copy link

+1

@shwill
Copy link

shwill commented May 11, 2017

I can still confirm that npm is not up to date, even if the version number seems to be correct.

@sidonaldson
Copy link

Is anyone available to fix this? I looks like there are a few tickets waiting on the NPM update (I believe this can't be a PR but apologies if I'm mistaken)

@lunarraid
Copy link

+1

@oliver-moran
Copy link
Collaborator

Apologies for the lack of publishes. Integrated most of the pull requests and made a publish to NPM just now.

Anybody willing to lend a hand working though the PRs is more than welcome: #219

Two notable things about this release:

  1. Exif handling is not backwards compatible. Previously JPEGs were automatically rotated according to exif data. Not the image.exifRotate() method will have to be manually called. I'm not bumping the major version number to mark this because we are still on version a major version 0.

  2. The browser version is broken (again). This is a very brittle part of the library and seems to regularly break for reasons unknown. Anybody willing and able to help fix that would be very welcome.

Thank you everyone who contributed to this version!

@arackaf
Copy link
Collaborator

arackaf commented May 21, 2017

Curious why you got rid of the auto-exif rotate - I thought that was a nice feature to have.

I assume image.exifRotate() is safe to call on all jpegs -- ie it will do nothing if nothing is needed?

@oliver-moran
Copy link
Collaborator

oliver-moran commented May 21, 2017

The reason was to do with this: #245

Rather than adding a options object to disable an opinionated feature, I decided to put control back in the hands of the developer.

image.exifRotate() is safe to call on all images. If no exif data is there it will just do nothing.

@arackaf
Copy link
Collaborator

arackaf commented May 21, 2017

Yeah - seems fair, especially when there's such a simple method which does this. lwip doesn't even have the method so you have to manually parse the exifData, determine which rotations are needed, then manually apply them. This is still a huge win over that :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants