Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File cannot be loaded with unsecured connection, when serviceWorker does not exist #328

Open
alex327512 opened this issue Sep 9, 2023 · 1 comment

Comments

@alex327512
Copy link

Hi everyone,

I found a case when the file cannot be loaded. It happens when the connection is unsecured (local environment, but it's not localhost). In this case popup just opens once.

Removing isSecureContext in the condition below helped, but it caused the error (The file at link was loaded over an insecure connection. This file should be served over HTTPS.)
if (isSecureContext && !('serviceWorker' in navigator))

Seems like it's not a good solution as well as forcing opening Iframe instead of popup.
Are there any other possible solutions?

Many thanks!

@daolanfler
Copy link

I encounter this problem too, I guess it just doesn't work when your connection is not over https (except localhost) , as both popup and iframe approach need serviceWorker to hijack request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants