Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support nested testdata directories #6

Open
johanbrandhorst opened this issue Aug 30, 2023 · 2 comments · May be fixed by #8
Open

Support nested testdata directories #6

johanbrandhorst opened this issue Aug 30, 2023 · 2 comments · May be fixed by #8

Comments

@johanbrandhorst
Copy link

Hi!

Thanks for this project. I found that it wasn't properly uploading nested testdata structures. I think you might need to add the packages path to the upload action, as when running fuzzing against a package the failing corpus is added to a testdata folder in that package. For example:

When running with packages: ./my/library/path and there is a fuzz failure, the fuzz failure is written to a folder like ./my/library/path/testdata/fuzz/FuzzFoo/beaed54bcc49cf987bf1995eacd23a30662c8da552ab0eeaea0e0540e2df24aa, but the action tries to upload the contents of the ./testdata directory.

Alternatively, perhaps the upload action could upload all testdata/fuzz folders?
jidicula added a commit that referenced this issue Sep 2, 2023
@jidicula
fix: Add packages input to upload path
cede727 
Resolves: #6
@jidicula jidicula linked a pull request Sep 2, 2023 that will close this issue
Open
@jidicula
Copy link
Owner

jidicula commented Sep 2, 2023

Thanks for this feedback @johanbrandhorst! I've opened up a PR at #8 - if you like, you can try out the action pointing to that branch (uses: jidicula/go-fuzz-action@jidicula/issue-6) in your workflow file. Let me know if that addresses the issue correctly and I'll merge the PR.

@johanbrandhorst
Copy link
Author

Thanks for the quick turnaround :). We've replaced our use of the action with a custom implementation for now, so we won't be able to test the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Add packages input to upload path jidicula/go-fuzz-action
2 participants
@johanbrandhorst @jidicula