Require list of cases for diagnoses

Author: jhauberg

Sources/CLI/main.swift

@@ -196,10 +196,9 @@ struct Doctor: ParsableCommand {
                 for: condition,
                 progress: activity
             ) {
-                if let references = diagnosis.cases?.sorted() {
-                    for reference in references {
-                        printdiag(text: reference, kind: .result)
-                    }
+                precondition(!diagnosis.cases.isEmpty)
+                for reference in diagnosis.cases.sorted() {
+                    printdiag(text: reference, kind: .result)
                 }
                 printdiag(text: diagnosis.conclusion, kind: .important)
                 if let supplemental = diagnosis.help {

Sources/XCDoctor/Diagnosis.swift

@@ -81,7 +81,7 @@ public struct Diagnosis {
     /**
      Represents a set of concrete cases that are directly linked to causing this diagnosis.
      */
-    public let cases: [String]?
+    public let cases: [String]
 }
 
 private func nonExistentFiles(in project: XcodeProject) -> [FileReference] {

Tests/DiagnosisTests.swift

@@ -20,7 +20,7 @@ class DiagnosisTests: XCTestCase {
         let diagnosis = examine(project: project, for: .nonExistentFiles)
         XCTAssertNotNil(diagnosis)
         XCTAssertNotNil(diagnosis!.cases)
-        XCTAssert(diagnosis!.cases!.count == 1)
+        XCTAssert(diagnosis!.cases.count == 1)
     }
 
     func testMissingFolder() {
@@ -32,7 +32,7 @@ class DiagnosisTests: XCTestCase {
         let diagnosis = examine(project: project, for: .nonExistentPaths)
         XCTAssertNotNil(diagnosis)
         XCTAssertNotNil(diagnosis!.cases)
-        XCTAssert(diagnosis!.cases!.count == 1)
+        XCTAssert(diagnosis!.cases.count == 1)
     }
 
     func testCorruptPlist() {
@@ -45,7 +45,7 @@ class DiagnosisTests: XCTestCase {
         let diagnosis = examine(project: project, for: condition)
         XCTAssertNotNil(diagnosis)
         XCTAssertNotNil(diagnosis!.cases)
-        XCTAssert(diagnosis!.cases!.count == 1)
+        XCTAssert(diagnosis!.cases.count == 1)
     }
 
     func testDanglingFile() {
@@ -58,7 +58,7 @@ class DiagnosisTests: XCTestCase {
         let diagnosis = examine(project: project, for: condition)
         XCTAssertNotNil(diagnosis)
         XCTAssertNotNil(diagnosis!.cases)
-        XCTAssert(diagnosis!.cases!.count == 1)
+        XCTAssert(diagnosis!.cases.count == 1)
     }
 
     func testEmptyGroups() {

Tests/XcodeProjectTests.swift

@@ -84,7 +84,7 @@ class XcodeProjectTests: XCTestCase {
         let diagnosis = examine(project: project, for: .nonExistentFiles)
         XCTAssertNotNil(diagnosis)
         XCTAssertNotNil(diagnosis!.cases)
-        XCTAssert(diagnosis!.cases!.count == 1)
+        XCTAssert(diagnosis!.cases.count == 1)
     }
 
     func testMissingFolder() {
@@ -96,7 +96,7 @@ class XcodeProjectTests: XCTestCase {
         let diagnosis = examine(project: project, for: .nonExistentPaths)
         XCTAssertNotNil(diagnosis)
         XCTAssertNotNil(diagnosis!.cases)
-        XCTAssert(diagnosis!.cases!.count == 1)
+        XCTAssert(diagnosis!.cases.count == 1)
     }
 
     func testCorruptPlist() {
@@ -109,7 +109,7 @@ class XcodeProjectTests: XCTestCase {
         let diagnosis = examine(project: project, for: condition)
         XCTAssertNotNil(diagnosis)
         XCTAssertNotNil(diagnosis!.cases)
-        XCTAssert(diagnosis!.cases!.count == 1)
+        XCTAssert(diagnosis!.cases.count == 1)
     }
 
     func testDanglingFile() {
@@ -122,7 +122,7 @@ class XcodeProjectTests: XCTestCase {
         let diagnosis = examine(project: project, for: condition)
         XCTAssertNotNil(diagnosis)
         XCTAssertNotNil(diagnosis!.cases)
-        XCTAssert(diagnosis!.cases!.count == 1)
+        XCTAssert(diagnosis!.cases.count == 1)
     }
 
     func testEmptyGroups() {