Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential buffer overrun in function init_send_receive_history #2

Open
npat-efault opened this issue Aug 6, 2015 · 0 comments
Open

Comments

@npat-efault
Copy link

In your code, in picocom.c, line 676, you should use "strcpy" instead of "strcat".
As you get "send_receive_history_file_path" from a "malloc", there is no guarantee that it will be zeroed-out.
This, or you should change "malloc" to "calloc".

https://github.com/jhandley/picocom/blob/master/picocom.c#L676

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant