Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Just a question #2

Open
stherrienaspnet opened this issue Oct 10, 2018 · 4 comments · Fixed by #25
Open

Just a question #2

stherrienaspnet opened this issue Oct 10, 2018 · 4 comments · Fixed by #25

Comments

@stherrienaspnet
Copy link

Can ngx-translate-cache work with rxjs 6.x?

Thanks

@jgpacheco
Copy link
Owner

@stherrienaspnet I haven't tested, but I don't see why not. If you find some issue please post it here.

@stherrienaspnet
Copy link
Author

Thanks you very much! I will let you know :)

@stherrienaspnet
Copy link
Author

Hello I have a made a migration from angular 5 to 7 and I'm getting these warning:
[email protected] requires a peer of @angular/core@^4.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN [email protected] requires a peer of rxjs@^5.1.0 but none is installed. You must install peer dependencies yourself.
npm WARN [email protected] requires a peer of @ngx-translate/core@^8.0.0 but none is installed. You must install peer dependencies yourself.

Do you think it is possible to update the some dependencies conditions? (^ by >= ) It all your tests still pass.

Thanks :)

@jgpacheco
Copy link
Owner

@stherrienaspnet PRs are welcome!
I will try to do it this weekend if you don't have the time. ;)

@jgpacheco jgpacheco linked a pull request Apr 7, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants