language detection should not be done

[DmitryEfimenko]

According to the ngx-translate examples, the translateService.use(lang) function should be called by the consumer application.

This makes sense because the functionality for getting the current language is a part of the business logic of the application. It can be different depending on the app's requirements.

For example, one application might use the short lang ids like en and ru. Another one might use longer locales: en-US and ru-RU. This means that this line of code will not work for these apps using longer locales. It will result in the TranslationLoader trying (and failing) to load en language when it needs to load en-US.

This is why I suggest removing the following lines completly from this fnction init:

const currentLang = this.getCachedLanguage() || this.translateService.getBrowserLang();
if (currentLang) { this.translateService.use(currentLang); }

Doing so will put the responsibility of calling translateService.use() on the developer of the app - just like it was initially intended by ngx-translate.

As a matter of fact, I don't think the init() function is necesary. The rest of its functionality could be easily placed in the constructor of the TranslateCacheService. This would simplify the API of the library while preserving the functionality.

In either case, this would be a breaking change. Although I understand the desire to avoid breaking changes, I believe this one is necessary.

What do you think?

[DmitryEfimenko]

any word on this?

[abashmak]

+1, I'm also burned by this issue.

[DmitryEfimenko]

well, it's time to switch to transloco...

[jgpacheco]

Reopening this issue since is not addressed by #9

[jgpacheco]

@DmitryEfimenko it will be a breaking change indeed.

[DmitryEfimenko]

Are you OK with it? If so, I can create a PR

[jgpacheco]

It makes perfect sense to me. Since is a breaking change, please bump major version and update the README.

[diosney]

Hi, any updates?

I use long locales ex: en-US and due the use of getBrowserLang at:

const currentLang = this.getCachedLanguage() || this.translateService.getBrowserLang();

this library is throwing an error looking from the wrong locale: en.

[DubeySandeep]

Hi @DmitryEfimenko, Are you working on this issue? Let me know I'll be happy to raise a PR if needed!

[DmitryEfimenko]

no, go ahead, @DubeySandeep