Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

for and tablerow tag arguments #78

Closed
jg-rp opened this issue Oct 25, 2022 · 0 comments
Closed

for and tablerow tag arguments #78

jg-rp opened this issue Oct 25, 2022 · 0 comments
Labels
incompatibility Behavioural differences between Python and Ruby Liquid

Comments

@jg-rp
Copy link
Owner

jg-rp commented Oct 25, 2022

Python Liquid's {% for %} and {% tablerow %} tags only accept integers (and variables that resolve to integers) as values for cols, offset and limit. String representations of numbers and floats should be acceptable too.

If a string arguments is given and that string can not be cast to an integer, a default value is used. The default value differs for each argument and/or tag.

There's also some inconsistent behaviour in the reference implementation when handling objects that do not have a to_i method. This requires further investigation.

@jg-rp jg-rp added the incompatibility Behavioural differences between Python and Ruby Liquid label Oct 25, 2022
@jg-rp jg-rp closed this as completed in a6fcd9a Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
incompatibility Behavioural differences between Python and Ruby Liquid
Projects
None yet
Development

No branches or pull requests

1 participant