Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recursive extends during static analysis #125

Closed
jg-rp opened this issue Aug 2, 2023 · 0 comments
Closed

Recursive extends during static analysis #125

jg-rp opened this issue Aug 2, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@jg-rp
Copy link
Owner

jg-rp commented Aug 2, 2023

When asynchronously analysing a template inheritance chain, we do not guard against recursive use of {% extends %}. Synchronous static analysis does keep track of extended templates for this reason.

liquid/liquid/static_analysis.py

Lines 554 to 556 in 0ad58c6

async def _analyze_template_inheritance_chain_async(
self, child: ChildNode, template: BoundTemplate
) -> None:

@jg-rp jg-rp added the bug Something isn't working label Aug 2, 2023
@jg-rp jg-rp closed this as completed in 8f3ba5a Aug 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jg-rp