You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Complementing existing unit test cases, we could include, in this repository, one or more implementation agnostic benchmark fixtures for Liquid.
I'm imagining at least one holistic Liquid template fixture covering all standard Liquid features, with well-defined, static template render context data and the expected result of rendering the template. This could be both a test case and a benchmark fixture.
Smaller macro (micro?) benchmark fixtures could also be useful for assessing the performance of Liquid tag implementations. For example, a fixture that targets the {% for %} tag while minimising the use of other Liquid constructs.
I note that the reference implementation of Liquid already has a benchmark fixture, but it mocks several Shopify specific tags and filters, and includes some Ruby specific massaging of its data. Also, it has not been updated in some time, so does not cover more recent tags, like {% liquid %} and {% render %}.
All benchmark fixtures added to this repository will be done so with the understanding that they are not a replacement for real-world, application specific benchmarks, and that some micro/macro benchmarks can produce some misleading results, especially when dealing with implementation specific caches and optimizers.
The text was updated successfully, but these errors were encountered:
Complementing existing unit test cases, we could include, in this repository, one or more implementation agnostic benchmark fixtures for Liquid.
I'm imagining at least one holistic Liquid template fixture covering all standard Liquid features, with well-defined, static template render context data and the expected result of rendering the template. This could be both a test case and a benchmark fixture.
Smaller macro (micro?) benchmark fixtures could also be useful for assessing the performance of Liquid tag implementations. For example, a fixture that targets the
{% for %}
tag while minimising the use of other Liquid constructs.I note that the reference implementation of Liquid already has a benchmark fixture, but it mocks several Shopify specific tags and filters, and includes some Ruby specific massaging of its data. Also, it has not been updated in some time, so does not cover more recent tags, like
{% liquid %}
and{% render %}
.All benchmark fixtures added to this repository will be done so with the understanding that they are not a replacement for real-world, application specific benchmarks, and that some micro/macro benchmarks can produce some misleading results, especially when dealing with implementation specific caches and optimizers.
The text was updated successfully, but these errors were encountered: