Skip to content
This repository has been archived by the owner on Apr 29, 2021. It is now read-only.

Does GetPwnedPassword even work? #10

Open
Robar666 opened this issue Sep 3, 2018 · 1 comment
Open

Does GetPwnedPassword even work? #10

Robar666 opened this issue Sep 3, 2018 · 1 comment

Comments

@Robar666
Copy link

Robar666 commented Sep 3, 2018

Hi,

as from what I see on https://github.com/jfversluis/BeenPwned.Api/blob/master/src/BeenPwned.Api/BeenPwnedClient.cs#L100 GetPwnedPassword always returns true if the response is 200 (OK)?

According to https://haveibeenpwned.com/API/v2#SearchingPwnedPasswordsByRange this will ALWAYS return 200 and the response have to be checked if the given password is really pwned.

Am I missing something out or is GetPwnedPassword currently not usable?

@EnCey EnCey mentioned this issue Sep 3, 2018
@jfversluis
Copy link
Owner

It seems some stuff has changed since I last checked this 🙂

Can't tell if it would not work at all at this point, but that might as well be the case.
Any PR's are gladly accepted

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants