Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support HTTP proxy #64

Merged
merged 1 commit into from
Apr 2, 2023
Merged

Support HTTP proxy #64

merged 1 commit into from
Apr 2, 2023

Conversation

yahavi
Copy link
Member

@yahavi yahavi commented Mar 25, 2023

  • All tests passed. If this feature is not already covered by the tests, I added new tests.

Fix #59

Proxy is already supported before that PR by adding the following system properties to the Maven command:

-Dartifactory.proxy.host=acme.jfrog.io 
-Dartifactory.proxy.port=8888 
-Dartifactory.proxy.username=elmar 
-Dartifactory.proxy.password=Wabbit

This PR enables configuring HTTP proxy in one of the following new ways:

  1. By the regular config:
<proxy>
    <host>acme.jfrog.io</host>
    <port>8888</port>
    <username>elmar</username>
    <password>Wabbit</password>
</proxy>
  1. By settings.xml:
<proxies>
    <proxy>
        <id>jfrog-proxy</id>
        <host>acme.jfrog.io</host>
        <port>8888</port>
        <username>elmar</username>
        <password>Wabbit</password>
    </proxy>
</proxies>

@yahavi yahavi added the new feature Automatically generated release notes label Mar 25, 2023
@yahavi yahavi requested a review from eyalbe4 March 25, 2023 15:39
@yahavi yahavi self-assigned this Mar 25, 2023
@yahavi yahavi mentioned this pull request Mar 25, 2023
@yahavi yahavi linked an issue Mar 25, 2023 that may be closed by this pull request
@yahavi yahavi merged commit 876a06f into jfrog:master Apr 2, 2023
@yahavi yahavi deleted the proxy branch April 2, 2023 10:41
@cb645j
Copy link

cb645j commented Feb 29, 2024

When will this be available? Im using the JFrogMaven@1 from azure devops extensions, i believe the JFrogMaven@1 uses this maven plugin, however it still does not read the proxy from my settings..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTTP Proxy not used Enable deployment through HTTP proxy
3 participants