Incomplete list of supported goals

[a-a-davydov]

Hello,

It seems list of goals to activate plugin in class AbstractMojo incomplete.

It is impossible to run mvn ... maven-deploy-plugin ..., maven understand only org.apache.maven.plugins:maven-deploy-plugin:deploy or deploy:deploy goals when we need to run exactly deploy directly.

So in current version we can use artifactory plugin only with goal 'deploy'

@mojo(name = "publish", defaultPhase = LifecyclePhase.VALIDATE, threadSafe = true)public class ArtifactoryMojo extends AbstractMojo { private static final SimpleDateFormat DATE_FORMAT = new SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ss.SSSZ"); private static final String[] DEPLOY_GOALS = {"deploy", "maven-deploy-plugin"};

[a-a-davydov]

Old version contains following check logic

final isDeployGoal = deployGoals.tokenize( ',' )*.trim().any {            String deployGoal -> session.goals.any {            String goal      -> (( goal == deployGoal ) || goal.contains( deployGoal ))            }        }

So old version check if goals list contains goal which contains maven-deploy-plugin

New code checks if goals list contains maven-deploy-plugin exactly:

 return session.getGoals().stream().anyMatch(goal -> ArrayUtils.contains(DEPLOY_GOALS, goal));

[a-a-davydov]

Seems valid list must be

String[] DEPLOY_GOALS = {"deploy", "deploy:deploy"}

[long76]

+1 here

[long76]

last version with worked with deployGoals is 2.6.1 but it's works only with Maven 3.8.x not 3.9.x