adds ability to remove contribution types when editing existing user #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #94 +/- ##
==========================================
+ Coverage 53.54% 54.43% +0.89%
==========================================
Files 19 19
Lines 409 417 +8
Branches 66 68 +2
==========================================
+ Hits 219 227 +8
Misses 161 161
Partials 29 29
Continue to review full report at Codecov.
|
kentcdodds
approved these changes
May 29, 2018
|
Thanks for the tip @kentcdodds. |
|
Hey @kentcdodds this (and #96) has been sitting idle for a good bit now. Is there anyone I can ping to get these reviewed? |
tyler-reitz
deleted the
enhancement/remove-contribution-types-when-editing-existing-user
branch
Berkmann18
pushed a commit
that referenced
this pull request
May 24, 2020
* docs: wip * Update README.md * delete files * docs: readme tweaks * motivation * motivation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Adds ability to remove contribution types from the command line
Why:
Provides an easy way to update existing contribution types
How:
Mostly, updates
formatContributions()insrc/contributors/add.jsto check for similarities/differences between theexistinguser's types and the newtypesthat are coming in and then either keep, add, or remove types.Checklist:
I kept getting formatting updates after the linting scripts ran. Let me know if these are not desireable as I tried deleting my own global
.eslintrcconfig but kept getting formatting updates once the script ran regardless.