Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added platform type #75

Merged
merged 1 commit into from
Nov 25, 2017

Conversation

kevinvangelder
Copy link
Contributor

What: Added platform type

Why: Approved addition: all-contributors/all-contributors#68

How:

Checklist:

  • Documentation
  • Tests
  • Ready to be merged
  • Added myself to contributors table

@codecov-io
Copy link

Codecov Report

Merging #75 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #75   +/-   ##
======================================
  Coverage    51.6%   51.6%           
======================================
  Files          18      18           
  Lines         312     312           
  Branches       39      39           
======================================
  Hits          161     161           
  Misses        136     136           
  Partials       15      15
Impacted Files Coverage Δ
src/util/contribution-types.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 383b3fd...ac9eb88. Read the comment docs.

@kevinvangelder
Copy link
Contributor Author

Wasn't able to run tests due to install errors.

Copy link
Collaborator

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful! Thank you :)

@kentcdodds kentcdodds merged commit 6fa55d5 into all-contributors:master Nov 25, 2017
@kentcdodds
Copy link
Collaborator

A new version of the CLI should be available soon.

Would you like to add yourself to the contributors table?

Berkmann18 pushed a commit that referenced this pull request May 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants