Enhancement/common errors files overridden #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The prior commit to this branch d4dc4e2 introduced an error in the util/config.js file where it checks for the length of the content.files property, whether that property exists in the config or not.
|
Sorry @kentcdodds I introduced an error with #96 that I caught while pulling in the latest release. This should undo my bonehead mistake. My apologies 🙏. |
kentcdodds
reviewed
Jun 20, 2018
Codecov Report
@@ Coverage Diff @@
## master #100 +/- ##
======================================
Coverage 58.5% 58.5%
======================================
Files 19 19
Lines 429 429
Branches 71 71
======================================
Hits 251 251
Misses 149 149
Partials 29 29
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
fixes an error I introduced in the last PR from this branch
Why:
The error check from the prior commits introduces an error when running the cli
How:
updates to util/config-file.js
Checklist: