Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - Photo library authorization doesnt work for limited access #144

Closed
ibraiz11 opened this issue Oct 27, 2023 · 3 comments · Fixed by #154
Closed

[BUG] - Photo library authorization doesnt work for limited access #144

ibraiz11 opened this issue Oct 27, 2023 · 3 comments · Fixed by #154
Assignees
Labels
confirmed bug A bug behavior that has been confirmed by maintainers

Comments

@ibraiz11
Copy link

Photo library authorization returns .authorized for limited access, It should return .limited.

To Reproduce
Steps to reproduce the behavior:

  1. Start the app first time and give limited access for photos.
  2. Select images and it will get you to your app
  3. if you use a logger or breakpoint then you will get .authorized not .limited as return value to JMPhotoPermissionManager.photo.authorizationStatus.

Expected behavior
I expect .limited access view to inflate not the .authorized gallery view.
JMPhotoPermissionManager.photo.authorizationStatus should be returning .limited

Desktop (please complete the following information):

  • OS: iOS

Smartphone (please complete the following information):

  • Device: iPhone 13 Pro
  • OS: iOS 16.7
  • Version 16.7

Additional context
Can be fixed in JPPhotoPermissionManager's authorizationStatus function to make it return accurate permission access.

@ibraiz11 ibraiz11 added the possible bug Something isn't working label Oct 27, 2023
@ibraiz11
Copy link
Author

The new API is available for iOS 14+ so that needs to be bumped up to 14 from 13. It's a simple fix so if you assign it to me I can make a PR.

@jevonmao
Copy link
Owner

@ibraiz11 Yes, feel free to open a PR but I would prefer an #if available so we don't lose compatibility on iOS 13.

@ibraiz11
Copy link
Author

ibraiz11 commented Oct 31, 2023

This will create an access level issue as PHAccess is only available from 14+.
The availabe annotation for 13 is not required for this class as changes are post 14 and the deprecated methods support back upto iOS 8.

@jevonmao jevonmao self-assigned this Feb 26, 2024
@jevonmao jevonmao added confirmed bug A bug behavior that has been confirmed by maintainers and removed possible bug Something isn't working labels Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed bug A bug behavior that has been confirmed by maintainers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants