Issue #7012 Replace geronimo spec jars with jakarta equivalents #7013
Conversation
Signed-off-by: Jan Bartel <[email protected]>
…7012-use-jakarta-jars
There was a problem hiding this comment.
The older jspDependencies() made it easier to understand what was being done and why in the various places it was being used.
The new boolean technique is awkward.
Please either restore jspDependencies() or make the parameter something else.
enum JettyFeatureEnum {
JSP, CDI
}
public static List<Option> coreJettyDependencies(JettyFeatureEnum ... feature) {and then used like ...
options.addAll(TestOSGiUtil.coreJettyDependencies(JSP));| public static Option optionalRemoteDebug() | ||
| { | ||
| return CoreOptions.when(Boolean.getBoolean("pax.exam.debug.remote")) | ||
| .useOptions(CoreOptions.vmOption("-Xrunjdwp:transport=dt_socket,server=y,suspend=y,address=5005")); | ||
| } | ||
|
|
||
| public static List<Option> coreJettyDependencies() | ||
| public static List<Option> coreJettyDependencies(boolean withJsp) |
There was a problem hiding this comment.
Can we just have a coreJspDependencies() instead of this boolean?
There was a problem hiding this comment.
OK, I've implemented it a different way. The problem is that the jakarta.transaction-api jar wants to use the javax.el* package, so we must deploy the jakarta.el-api jar to satisfy it, even though it won't be used. However, if we then subsequently configure the JSP bundles, we want to use the org.mortbay.jasper.apache-el jar instead because it provides both the api and impl. So in the latest solution I've removed the prior configuration of the jakarta.el-api jar.
|
@joakime nudge |
1 similar comment
|
@joakime nudge |
Closes #7012
Replace all geronimo spec jars by their jakarta equivalents (using the
javaxnamespace for jetty-10)