Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DynamicCapacity.release() #12083

Merged
merged 5 commits into from
Aug 29, 2024

Conversation

lorban
Copy link
Contributor

@lorban lorban commented Jul 24, 2024

Add assertions to DynamicCapacity to avoid entering an undetected corrupt state after it is released.

Fixes #12082

@lorban lorban added the Bug For general bugs on Jetty side label Jul 24, 2024
@lorban lorban requested review from gregw and joakime July 24, 2024 10:10
@lorban lorban self-assigned this Jul 24, 2024
@lorban lorban changed the base branch from jetty-12.0.x to jetty-12.1.x July 24, 2024 10:10
@lorban lorban requested a review from gregw August 6, 2024 09:47
@lorban lorban force-pushed the fix/jetty-12.1.x/DynamicCapacity-release branch from ff91257 to 68ba099 Compare August 7, 2024 14:09
@lorban lorban force-pushed the fix/jetty-12.1.x/DynamicCapacity-release branch from 68ba099 to ceba33f Compare August 7, 2024 14:10
@lorban lorban requested a review from sbordet August 7, 2024 17:57
@lorban
Copy link
Contributor Author

lorban commented Aug 13, 2024

@sbordet nudge

Copy link
Contributor

@sbordet sbordet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix is fine, but the rest is incomplete, I guess.

I'll approve this PR, but RBBP needs a large simplification.

@lorban lorban requested a review from gregw August 26, 2024 08:24
Copy link
Contributor

@gregw gregw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm OK with this... but I'm also OK for the checkNotReleased is only done if debug is enabled.

@lorban lorban merged commit 85d7d07 into jetty-12.1.x Aug 29, 2024
7 of 10 checks passed
@lorban lorban deleted the fix/jetty-12.1.x/DynamicCapacity-release branch August 29, 2024 13:53
@olamy olamy mentioned this pull request Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For general bugs on Jetty side
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

RetainableByteBuffer.DynamicCapacity enters a corrupt state when released
3 participants