Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing Test Jetty 11 - ServletContextHandlerTest.testAsyncServletRequestListenerListener #7777

Closed
olamy opened this issue Mar 24, 2022 · 3 comments · Fixed by #7960, #8066, #8332, #8339 or #8361
Closed

Failing Test Jetty 11 - ServletContextHandlerTest.testAsyncServletRequestListenerListener #7777

olamy opened this issue Mar 24, 2022 · 3 comments · Fixed by #7960, #8066, #8332, #8339 or #8361
Labels
Bug For general bugs on Jetty side Test

Comments

@olamy
Copy link
Member

olamy commented Mar 24, 2022

Jetty 11 build keep failing with this

java.lang.AssertionError: 

Expected: <2>
     but: was <9>
	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:6)
	at [email protected]/org.eclipse.jetty.servlet.ServletContextHandlerTest.testAsyncServletRequestListenerListener(ServletContextHandlerTest.java:1052)

https://jenkins.webtide.net/job/jetty.project/job/jetty-11.0.x/1026/testReport/
@olamy olamy added Bug For general bugs on Jetty side flaky-test labels Mar 24, 2022
@joakime
Copy link
Contributor

joakime commented Mar 24, 2022 •
edited
Loading

Should be looked at before we cut the Jetty 11.0.9 release?

@joakime joakime changed the title Flaky Test Jetty 11 ServletContextHandlerTest.testAsyncServletRequestListenerListener Failing Test Jetty 11 - ServletContextHandlerTest.testAsyncServletRequestListenerListener Mar 25, 2022
@joakime joakime added Test and removed flaky-test labels Mar 25, 2022
@joakime
Copy link
Contributor

joakime commented Mar 25, 2022

This isn't a flaky test, it's failing 100% of the time.

joakime added a commit that referenced this issue Mar 25, 2022
@joakime
Fix #7777 - ServletRequestListener init test fix
d3eedfc
@joakime
Copy link
Contributor

joakime commented Mar 25, 2022

Fixed in jetty-11.0.x (where it was failing)

@joakime joakime closed this as completed Mar 25, 2022
@olamy olamy mentioned this issue May 6, 2022
Merged
@olamy olamy mentioned this issue May 26, 2022
Merged
This was referenced Jul 25, 2022
Merged
Merged
Merged
@olamy olamy mentioned this issue Aug 13, 2022
Merged
@olamy olamy mentioned this issue Dec 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug For general bugs on Jetty side Test
Projects
None yet
Milestone
No milestone
2 participants
@olamy @joakime