Review XmlConfiguration locking #5095
Assignees
Comments
gregw
added a commit
that referenced
this issue
Aug 4, 2020
Use a pool of parsers rather than a shared static Signed-off-by: Greg Wilkins <[email protected]>
gregw
added a commit
that referenced
this issue
Aug 10, 2020
gregw
added a commit
that referenced
this issue
Aug 12, 2020
* Some updates to the new Pool class: + fixed a race with pending reservations + use a pending counter + Reservation API to simplify Entry API + removed public methods on Entry API * Some updates to the new Pool class: + fixed a race with pending reservations + use a pending counter + Reservation API to simplify Entry API + removed public methods on Entry API * Updates from review * Updates from review Tests for cache size and acquire with creator * Method no longer required with Reservation * update from the feedback on the feedback of the feedback from the review. Moved enable to Entry, removed Reservation class and clarified usage in javadoc * Issue #5095 XmlConfiguration locking Use pool instead of static shared instance fixed javadoc * Issue #5095 XmlConfiguration locking Use pool instead of static shared instance fixed javadoc * Issue #5095 XmlConfiguration locking Use pool instead of static shared instance fixed javadoc * Issue #5095 XmlConfiguration locking Use pool instead of static shared instance updates from review
gregw
added a commit
that referenced
this issue
Aug 24, 2020
* Issue #5095 XmlConfiguration Parser Pool Use a pool of parsers rather than a shared static Signed-off-by: Greg Wilkins <[email protected]> * Some updates to the new Pool class: + fixed a race with pending reservations + use a pending counter + Reservation API to simplify Entry API + removed public methods on Entry API * Some updates to the new Pool class: + fixed a race with pending reservations + use a pending counter + Reservation API to simplify Entry API + removed public methods on Entry API * Updates from review * Updates from review Tests for cache size and acquire with creator * Method no longer required with Reservation * update from the feedback on the feedback of the feedback from the review. Moved enable to Entry, removed Reservation class and clarified usage in javadoc * Issue #5095 XmlConfiguration locking Use pool instead of static shared instance * removed fake test Signed-off-by: Greg Wilkins <[email protected]> * Issue #5095 XmlConfiguration locking Use pool instead of static shared instance updates from review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Spawned by #5083.
Jetty version
9.4.x
Description
XmlConfigurationhas astaticinstance ofXmlParserand in the constructor locks on it and performs the parsing.This is fine from the locking point of view, but it grabs a JVM-wide lock so that
XmlConfigurations can only execute serially, which may not be desirable and may slow down startup.The JVM-wide
XmlParserinstance was created once for performance reasons due to costly initialization?Can we do better?
The text was updated successfully, but these errors were encountered: