Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IteratingCallback may iterate too much when process() returns Action.IDLE #12268

Closed
lorban opened this issue Sep 13, 2024 · 0 comments · Fixed by #12269
Closed

IteratingCallback may iterate too much when process() returns Action.IDLE #12268

lorban opened this issue Sep 13, 2024 · 0 comments · Fixed by #12269
Assignees
@lorban
Labels
Bug For general bugs on Jetty side

Comments

@lorban
Copy link
Contributor

lorban commented Sep 13, 2024 •
edited
Loading

Jetty version(s)
9.4.x, 10.0.x, 11.0.x, 12.0.x, 12.1.x

Description
When IteratingCallback.process() returns Action.IDLE, it incorrectly iterates one more time if another thread asks it to iterate and another processing has been scheduled.
@lorban lorban added the Bug For general bugs on Jetty side label Sep 13, 2024
@lorban lorban self-assigned this Sep 13, 2024
lorban added a commit that referenced this issue Sep 13, 2024
@lorban
#12268 reset _iterate flag when another processing is scheduled
5fb6ac6 
Signed-off-by: Ludovic Orban <[email protected]>
@lorban lorban mentioned this issue Sep 13, 2024
Merged
@lorban lorban moved this to 👀 In review in Jetty 12.0.14 Sep 13, 2024
@lorban lorban mentioned this issue Sep 13, 2024
Closed
lorban added a commit that referenced this issue Sep 13, 2024
@lorban
#12268 do not rely on time
c76b435 
Signed-off-by: Ludovic Orban <[email protected]>
lorban added a commit that referenced this issue Sep 13, 2024
@lorban
#12268 reset _iterate flag when another processing is scheduled
842b9c6 
Signed-off-by: Ludovic Orban <[email protected]>
@lorban lorban mentioned this issue Sep 13, 2024
Merged
lorban added a commit that referenced this issue Sep 13, 2024
@lorban
#12268 reset _iterate flag when another processing is scheduled
e721fed 
Signed-off-by: Ludovic Orban <[email protected]>
@lorban lorban mentioned this issue Sep 13, 2024
Merged
lorban added a commit that referenced this issue Sep 13, 2024
@lorban
#12268 reset _iterate flag when another processing is scheduled
2da18a0 
Signed-off-by: Ludovic Orban <[email protected]>
lorban added a commit that referenced this issue Sep 13, 2024
@lorban
#12268 reset _iterate flag when another processing is scheduled
4a209ce 
Signed-off-by: Ludovic Orban <[email protected]>
lorban added a commit that referenced this issue Sep 16, 2024
@lorban
#12268 reset _iterate flag when another processing is scheduled
2018c43 
Signed-off-by: Ludovic Orban <[email protected]>
lorban added a commit that referenced this issue Sep 16, 2024
@lorban
#12268 do not rely on time
ceee65a 
Signed-off-by: Ludovic Orban <[email protected]>
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Jetty 12.0.14 Sep 16, 2024
lorban added a commit that referenced this issue Sep 16, 2024
@lorban
#12268 reset _iterate flag when another processing is scheduled
85da950 
Signed-off-by: Ludovic Orban <[email protected]>
lorban added a commit that referenced this issue Sep 16, 2024
@lorban
#12268 reset _iterate flag when another processing is scheduled
c241a14 
Signed-off-by: Ludovic Orban <[email protected]>
@lorban lorban changed the title IteratingCallback iterates too much IteratingCallback iterates too much when process() returns Action.IDLE Sep 16, 2024
@lorban lorban changed the title IteratingCallback iterates too much when process() returns Action.IDLE IteratingCallback may iterate too much when process() returns Action.IDLE Sep 16, 2024
lorban added a commit that referenced this issue Sep 17, 2024
@lorban
#12268 add reproducer using jetty client
70eb2f2 
Signed-off-by: Ludovic Orban <[email protected]>
lorban added a commit that referenced this issue Sep 17, 2024
@lorban
#12268 add reproducer using jetty client
f0ae7c3 
Signed-off-by: Ludovic Orban <[email protected]>
lorban added a commit that referenced this issue Sep 17, 2024
@lorban
#12268 add reproducer using jetty client
72f9d13 
Signed-off-by: Ludovic Orban <[email protected]>
lorban added a commit that referenced this issue Sep 18, 2024
@lorban
#12268 add reproducer using jetty client
01937c9 
Signed-off-by: Ludovic Orban <[email protected]>
@lorban lorban mentioned this issue Oct 2, 2024
Closed
@olamy olamy mentioned this issue Oct 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lorban lorban

Labels
Bug For general bugs on Jetty side
Projects
No open projects
Jetty 12.0.14
Status: ✅ Done
Milestone
No milestone
1 participant
@lorban