Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jetty-12.1 ee11 tck test failures #11931

Closed
21 tasks done
janbartel opened this issue Jun 19, 2024 · 7 comments
Closed
21 tasks done

jetty-12.1 ee11 tck test failures #11931

janbartel opened this issue Jun 19, 2024 · 7 comments
Assignees
Labels
Bug For general bugs on Jetty side

Comments

@janbartel
Copy link
Contributor

janbartel commented Jun 19, 2024

Jetty version(s)
jetty-12.1

Jetty Environment
ee11

List of currently failing ee11 tck tests to fix (check means it's fixed):

  • servlet.tck.api.jakarta_servlet.servletcontext.ServletContextTests.GetMinorVersionTest
  • servlet.tck.api.jakarta_servlet_http.cookie.CookieTests.getValueQuotedTest
  • servlet.tck.api.jakarta_servlet_http.cookie.CookieTests.setMaxAgeZeroTest
  • servlet.tck.api.jakarta_servlet_http.cookie.CookieTests.setPartitionedTest
  • servlet.tck.api.jakarta_servlet_http.httpservletresponse.HttpServletResponseTests.sendError_StringTest
  • servlet.tck.api.jakarta_servlet_http.httpservletresponsewrapper.HttpServletResponseWrapperTests.sendError_StringTest
  • servlet.tck.api.jakarta_servlet_http.httpupgradehandler.HttpUpgradeHandlerTests.upgradeTest
  • servlet.tck.pluggability.api.jakarta_servlet.servletcontext.ServletContextTests.GetMinorVersionTest
  • servlet.tck.pluggability.api.jakarta_servlet_http.cookie.CookieTests.getValueQuotedTest
  • servlet.tck.pluggability.api.jakarta_servlet_http.cookie.CookieTests.setMaxAgeZeroTest
  • servlet.tck.pluggability.api.jakarta_servlet_http.cookie.CookieTests.setPartitionedTest
  • servlet.tck.pluggability.api.jakarta_servlet_http.httpservletresponse.HttpServletResponseTests.sendError_StringTest
  • servlet.tck.pluggability.api.jakarta_servlet_http.httpservletresponsewrapper.HttpServletResponseWrapperTests.sendError_StringTest
  • servlet.tck.pluggability.fragment.FragmentTests.initParamTest
  • servlet.tck.pluggability.fragment.FragmentTests.addServletURLTest
  • servlet.tck.pluggability.fragment.FragmentTests.filterOrderingTest
  • servlet.tck.pluggability.fragment.FragmentTests.addServletTest
  • servlet.tck.pluggability.fragment.FragmentTests.welcomefileTest
  • servlet.tck.signature.ServletSigTest.signatureTest
  • servlet.tck.spec.httpservletresponse.HttpServletResponseTests.flushBufferTest
  • servlet.tck.spec.serverpush.ServerPushTests.serverPushCookieTest
@janbartel janbartel added the Bug For general bugs on Jetty side label Jun 19, 2024
@janbartel janbartel self-assigned this Jun 19, 2024
@janbartel
Copy link
Contributor Author

janbartel commented Jun 20, 2024

Issue raised for TCK bug: jakartaee/servlet#660. This affects the tests:

  • servlet.tck.api.jakarta_servlet_http.httpservletresponse.HttpServletResponseTests.sendError_StringTest
  • servlet.tck.api.jakarta_servlet_http.httpservletresponsewrapper.HttpServletResponseWrapperTests.sendError_StringTest
  • servlet.tck.pluggability.api.jakarta_servlet_http.httpservletresponse.HttpServletResponseTests.sendError_StringTest
  • servlet.tck.pluggability.api.jakarta_servlet_http.httpservletresponsewrapper.HttpServletResponseWrapperTests.sendError_StringTest

Update 25/06/24: there is an error in jetty's handling of error messages in ee11, for which a fix will be necessary (see branch https://github.com/jetty/jetty.project/tree/jetty-12.1.x-tck-error-message)

@janbartel
Copy link
Contributor Author

janbartel commented Jun 20, 2024

Previously raised TCK bug: jakartaee/servlet#525 applies to:

  • servlet.tck.spec.httpservletresponse.HttpServletResponseTests.flushBufferTest

Latest failure is: https://jenkins.webtide.net/job/tck/job/tck-servlet-arquillian/job/jetty-12-ee11/36/testReport/junit/servlet.tck.spec.httpservletresponse/HttpServletResponseTests/flushBufferTest/

@janbartel
Copy link
Contributor Author

Need #10128 done in order for following test to pass:

  • servlet.tck.api.jakarta_servlet_http.httpupgradehandler.HttpUpgradeHandlerTests.upgradeTest

@janbartel
Copy link
Contributor Author

janbartel commented Jun 20, 2024

Raised jetty issue #11934 to fix:

  • servlet.tck.api.jakarta_servlet_http.cookie.CookieTests.getValueQuotedTest
  • servlet.tck.pluggability.api.jakarta_servlet_http.cookie.CookieTests.getValueQuotedTest

Fixed via #11936

@janbartel
Copy link
Contributor Author

janbartel commented Jun 20, 2024

Raised TCK bug: jakartaee/servlet#661 applies to:

  • servlet.tck.spec.serverpush.ServerPushTests.serverPushCookieTest

Bug report not accepted, need to modify Jetty.

@janbartel
Copy link
Contributor Author

Raised jetty issue #12004 to look at:

  • servlet.tck.signature/ServletSigTest/signatureTest/

@janbartel
Copy link
Contributor Author

@github-project-automation github-project-automation bot moved this to ✅ Done in Jetty 12.1.0 Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For general bugs on Jetty side
Projects
Status: ✅ Done
Development

No branches or pull requests

1 participant