Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jetty Websocket should have some API to handle timeouts #11358

Closed
lorban opened this issue Jan 30, 2024 · 0 comments
Closed

Jetty Websocket should have some API to handle timeouts #11358

lorban opened this issue Jan 30, 2024 · 0 comments
Assignees
@lachlan-roberts
Labels
Enhancement Low Priority

Comments

@lorban
Copy link
Contributor

lorban commented Jan 30, 2024

Jetty version(s)
12.0.x

Enhancement Description
Currently, when WebSocketConnection.onIdleExpired or WebSocketConnection.onReadTimeout is called, the user of the API has no way to handle the timeout. CometD would be a prime user of this feature as it has its own timeout mechanism that currently clashes with the websocket one.

We should add some API with which a user could plug a timeout handler, akin to what request.addIdleTimeoutListener() works for the Jetty Core API.
@lorban lorban added this to the 12.0.x milestone Jan 30, 2024
lachlan-roberts added a commit that referenced this issue Oct 9, 2024
@lachlan-roberts
Issue #11358 - Add API to handle timeouts in WebSocket
cb1a880 
Signed-off-by: Lachlan Roberts <[email protected]>
@lachlan-roberts lachlan-roberts mentioned this issue Oct 9, 2024
Merged
lachlan-roberts added a commit that referenced this issue Oct 15, 2024
@lachlan-roberts
Merge pull request #12359 from jetty/jetty-12.1.x-11358-websocketTime…
d43241b 
…outs

Issue #11358 - Add API to handle timeouts in WebSocket
@lachlan-roberts lachlan-roberts moved this to ✅ Done in Jetty 12.1.0 Oct 15, 2024
@lachlan-roberts lachlan-roberts removed this from the 12.0.x milestone Oct 15, 2024
@olamy olamy mentioned this issue Oct 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lachlan-roberts lachlan-roberts

Labels
Enhancement Low Priority
Projects
Jetty 12.1.0
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@joakime @lorban @lachlan-roberts