Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TLS handshake failures leak HttpConnection.RequestTimeouts tasks #10786

Closed
sbordet opened this issue Oct 25, 2023 · 0 comments · Fixed by #10795
Closed

TLS handshake failures leak HttpConnection.RequestTimeouts tasks #10786

sbordet opened this issue Oct 25, 2023 · 0 comments · Fixed by #10795
Assignees
@gregw
Labels
Bug For general bugs on Jetty side Sponsored This issue affects a user with a commercial support agreement

Comments

@sbordet
Copy link
Contributor

sbordet commented Oct 25, 2023

Jetty version(s)
10+

Description
When a TLS failure happens during the TLS handshake, the connection is closed, but the HttpConnection.RequestTimeouts is not destroyed, leaking the scheduler task inside the Wakeup instance.
@sbordet sbordet added Bug For general bugs on Jetty side Sponsored This issue affects a user with a commercial support agreement labels Oct 25, 2023
@gregw gregw self-assigned this Oct 26, 2023
sbordet added a commit that referenced this issue Oct 26, 2023
@sbordet
Fixes #10786 - TLS handshake failures leak HttpConnection.RequestTime…
fa166d0 
…outs tasks

Moved the call to destroy the CyclicTimeouts to a close() call that is always called.

Fixed NPE in ManagedSelector.getTotalKeys().

Fixed exception handling to avoid infinite recursion in SslConnection.

Signed-off-by: Simone Bordet <[email protected]>
@sbordet sbordet linked a pull request Oct 26, 2023 that will close this issue
Fixes #10786 - TLS handshake failures leak HttpConnection.RequestTime… #10795
Merged
sbordet added a commit that referenced this issue Oct 26, 2023
@sbordet
Merge pull request #10795 from jetty/fix/jetty-10-10786-tls-handshake…
95804f6 
…-scheduler-leak

Fixes #10786 - TLS handshake failures leak HttpConnection.RequestTime…
@wendigo wendigo mentioned this issue Nov 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gregw gregw

Labels
Bug For general bugs on Jetty side Sponsored This issue affects a user with a commercial support agreement
Projects
No open projects
Jetty 10.0.18 / 11.0.18 - FROZEN
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #10786 - TLS handshake failures leak HttpConnection.RequestTime… jetty/jetty.project
2 participants
@gregw @sbordet