Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EE9 Copies HttpFields in response #10416

Closed
gregw opened this issue Aug 27, 2023 · 0 comments · Fixed by #10417
Closed

EE9 Copies HttpFields in response #10416

gregw opened this issue Aug 27, 2023 · 0 comments · Fixed by #10417
Labels
Bug For general bugs on Jetty side

Comments

@gregw
Copy link
Contributor

gregw commented Aug 27, 2023

Jetty version(s)
12.0.0

Jetty Environment
ee8, ee9

Description

Discovered in #10359 is that EE9 currently copies the response headers, so that persistent headers like Server and Date are not well handled. There as also some TODOs regarding the efficiency of the copy.

@gregw gregw added the Bug For general bugs on Jetty side label Aug 27, 2023
gregw added a commit that referenced this issue Aug 27, 2023
Use the core response HttpFields directly as the ee9 response headers to avoid copy and retain persistent field behaviour.
@gregw gregw linked a pull request Aug 27, 2023 that will close this issue
gregw added a commit that referenced this issue Aug 28, 2023
Use the core response HttpFields directly as the ee9 response headers to avoid copy and retain persistent field behaviour.

Added EE9 test to show that Persistent fields can be modified

Updated fix for #10339 so that persistent fields revert to original values after a clear operation
gregw added a commit that referenced this issue Aug 28, 2023
Use the core response HttpFields directly as the ee9 response headers to avoid copy and retain persistent field behaviour.
Fix #10416 EE9 Response headers
Added EE9 test to show that Persistent fields can be modified
Updated fix for #10339 so that persistent fields revert to original values after a clear operation
@gregw gregw moved this to ✅ Done in Jetty 12.0.1 - FROZEN Aug 28, 2023
@gregw gregw closed this as completed Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For general bugs on Jetty side
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant