Add killjoy message to the response when > MAX_POINTS #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just like `Buzzkill Mode TM` from the Hipchat karma bot, this prints out a message explaining the 5 (or MAX_POINTS) limit if someone is giving (or taking away) more karma. closes jetpackworkflow#4 the rest of the way
diachini
commented
Feb 9, 2019
| @@ -43,6 +43,7 @@ module.exports = (robot) -> | |||
| reasonsKeyword = process.env.HUBOT_PLUSPLUS_REASONS or 'raisins' | |||
| maxPoints = process.env.HUBOT_PLUSPLUS_MAX_POINTS or 5 | |||
| reasonConjunctions = process.env.HUBOT_PLUSPLUS_CONJUNCTIONS or 'for|because|cause|cuz|as' | |||
| killjoyMessage = process.env.HUBOT_PLUSPLUS_KILLJOY_MESSAGE or 'Killjoy Mode™ has enforced a maximum change of ' + maxPoints + ' points' | |||
There was a problem hiding this comment.
I know the ™ for Buzzkill Mode™ is probably not an enforceable trademark.. but just to be safe, I went with Killjoy Mod™ instead 🤷♂️
@regentgal lemme know whatcha think!
regentgal
suggested changes
Apr 15, 2020
| @@ -18,6 +18,7 @@ API | |||
| * `'taco tuesday'++` - add a point to 'taco tuesday' | |||
| * `++` - add a point to the most previously voted-on thing | |||
| * `thing++ for stuff` - keep track of why you gave thing points | |||
| * `thing+++++++` - adding more than `HUBOT_PLUSPLUS_MAX_POINTS` points will be capped at the max and a `HUBOT_PLUSPLUS_KILLJOY_MESSAGE` will be appended to the updated score. | |||
There was a problem hiding this comment.
i think this will be self explanatory when it happens and no one besides us will understand that those constants are. delete this line, and I'll approve.
|
testing works |
|
As soon as documentation changes are made, I'll merge. |
|
I've come to enjoy not being yelled at by jetbot when you try to give more than 5 karma at a time. I'm gonna close this since I don't foresee myself getting this across the finish line. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just like
Buzzkill Mode TMfrom the Hipchat karma bot, this prints outa message explaining the 5 (or MAX_POINTS) limit if someone is giving
(or taking away) more karma.
closes #4 the rest of the way