Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message Board Updates [Courses] #543

Closed
8 tasks done
JonEsparaz opened this issue Dec 28, 2020 · 4 comments · Fixed by #560
Closed
8 tasks done

Message Board Updates [Courses] #543

JonEsparaz opened this issue Dec 28, 2020 · 4 comments · Fixed by #560
Assignees

Comments

@JonEsparaz
Copy link
Collaborator

JonEsparaz commented Dec 28, 2020

This issue primarily applies to courses, but the features updates can be applied to all message boards.

Threaded conversations:

  • Add Reply table to schema
  • One-to-many connection: Message to Reply (schema)
  • One-to-many (recursive) connection: Reply to Reply (schema)
  • Add reply button and client-side logic to handle replies
  • Display conversation threads by indenting replies

Note: the Figma mockups suggest that replies only go three layers deep (i.e. top level message, replies to that message and replies to those replies), but a recursive connection will be used to maintain future flexibility.

Other updates:

  • Implement infinite scroll
  • Load messages incrementally
  • Update styling and UI to better match mockups
@JonEsparaz JonEsparaz self-assigned this Dec 28, 2020
@GeorgeBellTMH
Copy link
Contributor

Sounds good! Can you also make a allowReplies="true|false" so we can disable it in cases where it doesn't make sense to have replies...

@GeorgeBellTMH
Copy link
Contributor

Also, I think it might also not be clear in the design, but in some cases we have newest->oldest and some cases oldest->newest and top/bottom message input...

I think it also would be useful if we could have ability to have profileImage="big|small|none" and name="show|hover" and editorTools="show|hide" as there are times/places where we can hide some of that stuff....

@JonEsparaz
Copy link
Collaborator Author

Yes, I'll definitely add those props to the component.

@JonEsparaz
Copy link
Collaborator Author

Progress report: everything is mostly done - I did run into a couple unexpected issues.

Just testing and cleaning up the UI a bit. PR will be up on Monday by the latest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants