Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Replace deprecated findDOMNode call #9052

Closed
wants to merge 2 commits into from
Closed

[WIP] Replace deprecated findDOMNode call #9052

wants to merge 2 commits into from

Conversation

coelhucas
Copy link

Summary

Closes #9043 by replacing the deprecated .findDOMNode call with the useRef React hook.

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@coelhucas coelhucas changed the title Remove deprecated findDOMNode call Replace deprecated findDOMNode call Oct 14, 2019
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@coelhucas coelhucas changed the title Replace deprecated findDOMNode call [WIP] Replace deprecated findDOMNode call Oct 15, 2019
thymikee
thymikee previously approved these changes Oct 15, 2019
Copy link
Collaborator

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there anything more you'd like to add, that it's still WIP? :) LGTM so far, just make sure tests are still passing

@thymikee thymikee dismissed their stale review October 15, 2019 10:07

tests need to be fixed

@SimenB
Copy link
Member

SimenB commented Apr 28, 2020

This was fixed in #9124. Thanks for the PR though!

@SimenB SimenB closed this Apr 28, 2020
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

findDomNode is deprecated
4 participants