feat(circus): added each to failing tests #13142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkyusufk
commented
Aug 17, 2022
SimenB
requested changes
Aug 17, 2022
There was a problem hiding this comment.
thanks! can you add a changelog entry as well? plus update the docs (https://github.com/facebook/jest/blob/main/docs/GlobalAPI.md)
SimenB
reviewed
Aug 17, 2022
mrazauskas
reviewed
Aug 17, 2022
SimenB
reviewed
Aug 17, 2022
…jest into feat/add-each-in-failing-tests
SimenB
reviewed
Aug 17, 2022
mrazauskas
reviewed
Aug 17, 2022
Co-authored-by: Tom Mrazauskas <[email protected]>
mrazauskas
reviewed
Aug 17, 2022
Co-authored-by: Tom Mrazauskas <[email protected]>
|
@SimenB @mrazauskas Thanks for the reviews! This was my very first contribution to jest and hopefully many more to come🚀 |
SimenB
changed the title
|
Thank you! |
Merged
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds the new feature mentioned in this issue #13084
Also added new tests to make sure the new feature is working well.
Test plan
Added unit tests to make sure that the functionality is working