Upgrade fsevents in jest-haste-map #11428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good stuff 👍 Please run |
|
@SimenB done! |
SimenB
approved these changes
May 20, 2021
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The current version of
fseventscontains bug fixes for M1 Apple Silicon chips.Specifically, a React Native app could not be started on M1 laptops in Xcode, because of the error message
Error: EMFILE: too many open files, watch. Quite a few people are affected by it, see: facebook/metro#668Test plan
I have isolated this change and verified that upgrading fsevents is the turnkey solution.
Fast refresh, the main feature relying on file watching operations, is still working just fine.