chore(jest-transform): refactor transformer API to reduce number of arguments #10834
Conversation
SimenB
changed the title
| @@ -1,80 +1,98 @@ | |||
| // Jest Snapshot v1, https://goo.gl/fbAQLP | |||
|
|
|||
| exports[`ScriptTransformer passes expected transform options to getCacheKey 1`] = ` | |||
| Object { | |||
There was a problem hiding this comment.
ignore whitespace: https://github.com/facebook/jest/pull/10834/files?w=1
| "unmockedModulePathPatterns": undefined, | ||
| "watchPathIgnorePatterns": Array [], | ||
| }, | ||
| "configString": "{\\"automock\\":false,\\"cache\\":true,\\"cacheDirectory\\":\\"/cache/\\",\\"clearMocks\\":false,\\"coveragePathIgnorePatterns\\":[],\\"cwd\\":\\"/test_root_dir/\\",\\"detectLeaks\\":false,\\"detectOpenHandles\\":false,\\"errorOnDeprecated\\":false,\\"extraGlobals\\":[],\\"forceCoverageMatch\\":[],\\"globals\\":{},\\"haste\\":{},\\"injectGlobals\\":true,\\"moduleDirectories\\":[],\\"moduleFileExtensions\\":[\\"js\\"],\\"moduleLoader\\":\\"/test_module_loader_path\\",\\"moduleNameMapper\\":[],\\"modulePathIgnorePatterns\\":[],\\"modulePaths\\":[],\\"name\\":\\"test\\",\\"prettierPath\\":\\"prettier\\",\\"resetMocks\\":false,\\"resetModules\\":false,\\"restoreMocks\\":false,\\"rootDir\\":\\"/\\",\\"roots\\":[],\\"runner\\":\\"jest-runner\\",\\"setupFiles\\":[],\\"setupFilesAfterEnv\\":[],\\"skipFilter\\":false,\\"skipNodeResolution\\":false,\\"slowTestThreshold\\":5,\\"snapshotSerializers\\":[],\\"testEnvironment\\":\\"node\\",\\"testEnvironmentOptions\\":{},\\"testLocationInResults\\":false,\\"testMatch\\":[],\\"testPathIgnorePatterns\\":[],\\"testRegex\\":[\\"\\\\\\\\.test\\\\\\\\.js$\\"],\\"testRunner\\":\\"jest-jasmine2\\",\\"testURL\\":\\"http://localhost\\",\\"timers\\":\\"real\\",\\"transform\\":[[\\"\\\\\\\\.js$\\",\\"test_preprocessor\\",{}]],\\"transformIgnorePatterns\\":[\\"/node_modules/\\"],\\"watchPathIgnorePatterns\\":[]}", |
There was a problem hiding this comment.
Looking at this snapshot and thinking if we need to bust the transform cache when any of the configuration options change? Wouldn't it be sufficient to only reset cache when transform output affecting config is changed, like cache, transform, cacheDirectory, extraGlobals? Downside would be maintaining such a list
There was a problem hiding this comment.
Downside would be maintaining such a list
exactly this. Might be worth it, tho
SimenB
force-pushed
the
refactor-transform-arguments
branch
from
8349594 to
afca168
Compare
| @@ -144,6 +144,7 @@ | |||
| }, | |||
| "resolutions": { | |||
| "@types/jest/jest-diff": "^25.1.0", | |||
| "@types/jest/pretty-format": "^25.1.0" | |||
| "@types/jest/pretty-format": "^25.1.0", | |||
| "fbjs-scripts": "patch:fbjs-scripts@^1.1.0#./patches/fbjs-scripts.patch" | |||
which docs? |
Co-authored-by: Michał Pierzchała <[email protected]>
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Sorta for #10823 (comment). While writing the docs the arguments jumped out to me, so decided to refactor the code.
Test plan
Existing tests should pass, tweaked others