Internal: package dependency cycles

[SimenB]

Noticed these when publishing a release

lerna WARN ECYCLE Dependency cycles detected, you should fix these!
lerna WARN ECYCLE jest-circus -> jest-runtime -> jest-config -> @jest/test-sequencer -> jest-runner -> jest-circus
lerna WARN ECYCLE jest-jasmine2 -> (nested cycle: jest-circus -> jest-runtime -> jest-config -> @jest/test-sequencer -> jest-runner -> jest-circus) -> jest-jasmine2
lerna WARN ECYCLE (nested cycle: jest-jasmine2 -> (nested cycle: jest-circus -> jest-runtime -> jest-config -> @jest/test-sequencer -> jest-runner -> jest-circus) -> jest-jasmine2) -> (nested cycle: jest-jasmine2 -> (nested cycle: jest-circus -> jest-runtime -> jest-config -> @jest/test-sequencer -> jest-runner -> jest-circus) -> jest-jasmine2)
lerna WARN ECYCLE Dependency cycles detected, you should fix these!
lerna WARN ECYCLE jest-config -> @jest/test-sequencer -> jest-runner -> jest-config
lerna WARN ECYCLE jest-jasmine2 -> jest-runtime -> (nested cycle: jest-config -> @jest/test-sequencer -> jest-runner -> jest-config) -> jest-jasmine2
lerna WARN ECYCLE (nested cycle: jest-jasmine2 -> jest-runtime -> (nested cycle: jest-config -> @jest/test-sequencer -> jest-runner -> jest-config) -> jest-jasmine2) -> (nested cycle: jest-jasmine2 -> jest-runtime -> (nested cycle: jest-config -> @jest/test-sequencer -> jest-runner -> jest-config) -> jest-jasmine2)
lerna WARN ECYCLE Dependency cycles detected, you should fix these!
lerna WARN ECYCLE jest-config -> @jest/test-sequencer -> jest-runner -> jest-config
lerna WARN ECYCLE jest-jasmine2 -> jest-runtime -> (nested cycle: jest-config -> @jest/test-sequencer -> jest-runner -> jest-config) -> jest-jasmine2
lerna WARN ECYCLE (nested cycle: jest-jasmine2 -> jest-runtime -> (nested cycle: jest-config -> @jest/test-sequencer -> jest-runner -> jest-config) -> jest-jasmine2) -> (nested cycle: jest-jasmine2 -> jest-runtime -> (nested cycle: jest-config -> @jest/test-sequencer -> jest-runner -> jest-config) -> jest-jasmine2)

I think it's types causing these, but haven't investigated

[WeiAnAn]

I found these two place of type import causing dependency cycles.

https://github.com/facebook/jest/blob/2edd5c4724cfadb944a6a233a7ad8fb5a3e05996/packages/jest-test-sequencer/src/index.ts#L11-L12
https://github.com/facebook/jest/blob/2edd5c4724cfadb944a6a233a7ad8fb5a3e05996/packages/jest-jasmine2/src/index.ts#L13

I try to move dependencies to devDependencies in package.json, but lerna still show the warning.
It work with removing those dependencies.
I'm not sure if it cause any error. I think we have references config in tsconfig.json, it should work fine.

[ghostd]

It seems we have something like this:
jest-jasmine2 needs jest-runtime, jest-runtime needs jest-config, jest-config needs jest-jasmine2 to load the test runner in normalize.ts
https://github.com/facebook/jest/blob/8294bab1ebbf9bac7d2aa01abd256bbca4952eb7/packages/jest-config/src/normalize.ts#L557-L559

[SimenB]

Thanks for digging into it!

jest-runtime shouldn't need jest-config (nothing except @jest/core and possibly jest-cli should need jest-config). It seems it's just for the runtime CLI. I think we should just split out jest-runtime-cli to a separate module in Jest 27. I highly doubt anyone is using it, so might even just delete it...

jest-jasmine2 (and jest-circus) needs jest-runtime for its types.

[SimenB]

I opened up #10011 for that one.

jest-runner depends on jest-config for getTestEnvironment - should probably just make this less magical and just depend require these modules to be fully named (discussed in #5913)

[SimenB]

As of 26.2.0, FWIW

lerna WARN ECYCLE Dependency cycles detected, you should fix these!
lerna WARN ECYCLE jest-circus -> jest-runner -> jest-circus
lerna WARN ECYCLE jest-config -> @jest/test-sequencer -> (nested cycle: jest-circus -> jest-runner -> jest-circus) -> jest-config
lerna WARN ECYCLE jest-jasmine2 -> jest-runtime -> (nested cycle: jest-config -> @jest/test-sequencer -> (nested cycle: jest-circus -> jest-runner -> jest-circus) -> jest-config) -> jest-jasmine2
lerna WARN ECYCLE (nested cycle: jest-jasmine2 -> jest-runtime -> (nested cycle: jest-config -> @jest/test-sequencer -> (nested cycle: jest-circus -> jest-runner -> jest-circus) -> jest-config) -> jest-jasmine2) -> (nested cycle: jest-jas
mine2 -> jest-runtime -> (nested cycle: jest-config -> @jest/test-sequencer -> (nested cycle: jest-circus -> jest-runner -> jest-circus) -> jest-config) -> jest-jasmine2)
lerna WARN ECYCLE Dependency cycles detected, you should fix these!
lerna WARN ECYCLE jest-config -> @jest/test-sequencer -> jest-runner -> jest-config
lerna WARN ECYCLE jest-jasmine2 -> jest-runtime -> (nested cycle: jest-config -> @jest/test-sequencer -> jest-runner -> jest-config) -> jest-jasmine2
lerna WARN ECYCLE (nested cycle: jest-jasmine2 -> jest-runtime -> (nested cycle: jest-config -> @jest/test-sequencer -> jest-runner -> jest-config) -> jest-jasmine2) -> (nested cycle: jest-jasmine2 -> jest-runtime -> (nested cycle: jest-c
onfig -> @jest/test-sequencer -> jest-runner -> jest-config) -> jest-jasmine2)
lerna WARN ECYCLE Dependency cycles detected, you should fix these!
lerna WARN ECYCLE jest-config -> @jest/test-sequencer -> jest-runner -> jest-config
lerna WARN ECYCLE jest-jasmine2 -> jest-runtime -> (nested cycle: jest-config -> @jest/test-sequencer -> jest-runner -> jest-config) -> jest-jasmine2
lerna WARN ECYCLE (nested cycle: jest-jasmine2 -> jest-runtime -> (nested cycle: jest-config -> @jest/test-sequencer -> jest-runner -> jest-config) -> jest-jasmine2) -> (nested cycle: jest-jasmine2 -> jest-runtime -> (nested cycle: jest-c
onfig -> @jest/test-sequencer -> jest-runner -> jest-config) -> jest-jasmine2)

[ghostd]

After some "grepping", i found this dependencies cycle:

• jest-runner needs jest-config for getTestEnvironment (called by runTestInternal)
• jest-config needs jest-circus to load the test runner with options.testRunner = require.resolve('jest-circus/runner');
• jest-circus needs jest-runner to import the type TestFileEvent (in jestAdapterInit.ts, jestAdapter.ts, and testCaseReportHandler.ts);
• we have a loop ;-)

@SimenB any advices to break this cycle?

[SimenB]

We could move getTestEnvironment to jest-util I guess?

[ghostd]

Ok, i'll take a look this weekend.

[ghostd]

I quickly looked over. If we move getTestEnvironment in jest-utils, we also have to move resolveWithPrefix with it, but this function needs Resolver from the jest-resolve package... which depends on jest-utils... we have created an other cycle :)

Maybe we can move getTestEnvironment and resolveWithPrefix into jest-resolve, i can give a shot. Does it make sense to you, or this is not pertinent?

[SimenB]

Moving resolveWithPrefix into jest-resolve seems fine. getTestEnvironment seems to not belong there, though... Let's start with resolveWithPrefix?

[SimenB]

Resolved in #11466

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.