localStorage expected numbers returning strings in [email protected] update

[anselmbradford]

💥 Regression Report

I work on a project that simulates an object store with this module. The global localStorage is set to this simulated version here. The test checks for a number being set in the store. In 23.4.1 this works. In 23.4.2 I get the error Expected number but received string., and the returned value is "1" and not 1.

Possibly related to the update to resolve jsdom/jsdom#2304

Last working version

Worked up to version: 23.4.1

Stopped working in version: 23.4.2

To Reproduce

Hmm… well you could try https://github.com/cfpb/cfgov-refresh#quickstart, update jest in package.json, and run gulp test:unit

Expected behavior

Data types should not change.

Link to repl or repo (highly encouraged)

See Regression Report.

Run npx envinfo --preset jest

Paste the results here:

  System:
    OS: macOS Sierra 10.12.6
    CPU: x64 Intel(R) Core(TM) i7-4980HQ CPU @ 2.80GHz
  Binaries:
    Node: 8.11.1 - ~/.nvm/versions/node/v8.11.1/bin/node
    Yarn: 1.7.0 - ~/homebrew/bin/yarn
    npm: 5.6.0 - ~/.nvm/versions/node/v8.11.1/bin/npm
  npmPackages:
    jest: 23.4.2 => 23.4.2

[thymikee]

This is probably a fix in your storageMock library or JSDOM, possibly you'll need to set "testURL": "http://localhost" (see #6792). localStorage should serialize every value to string. It's a pitty it actually accepts non-strings as arguments, because it's misleading.

[emceearjun]

Can anyone tell me if this fix has been published to npm?

[SimenB]

There is no bug (or fix) for jest here. Jest has nothing to do with local storage, you probably upgraded jsdom

[anselmbradford]

There is no bug (or fix) for jest here. Jest has nothing to do with local storage, you probably upgraded jsdom

Looking at the package-lock.json, this is true, jsdom went from 11.11.0 to 11.12.0, I guess because of the caret here. I'll snoop around jsdom for what changed in that minor update. Thanks!

[anselmbradford]

And here we are jsdom/jsdom@11.11.0...master#diff-9b8fab691c00b9e5380b19ce882f3271R3

[SimenB]

jsdom implemented localstorage. Your old implementation was buggy, as can be seen by @thymikee's examples

[anselmbradford]

Yup that was it, thanks for the help!

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.