[Feature]: Migrate to Prettier v3

[sosukesuzuki]

🚀 Feature Proposal

Hi, I am a maintainer at Prettier.

The Prettier team is currently working on v3 (still alpha).
v3 will include breaking changes. (Detailed changelog is here: https://github.com/prettier/prettier/releases/tag/3.0.0-alpha.1)

For example, the all of public APIs will be async (changelog). Jest inline snapshots will probably be affected by this.

If you have any questions, feel free to mention us. We can help you.

If you have already migrated to Prettier v3, sorry but please close this issue.

Motivation

• Allow Jest to follow Prettier changes

Example

N/A

Pitch

Jest inline snapshots that uses Prettier as a library, is included in Jest core

[SimenB]

Thanks for opening up an issue!

For example, the all of public APIs will be async (changelog). Jest inline snapshots will probably be affected by this.

That means we probably won't ever be able to migrate - I don't think we wanna make snapshot matchers async. We could possibly have some codemod or similar, but I'm not too sure about that...

What we can do is probably just drop the prettier usage in the inline snapshots and solely use the babel approach which was released in Jest 27.

[liuxingbaoyu]

https://github.com/babel/babel/blob/main/packages/babel-register/src/worker/index.js
This may be an option in the future.

By the way, this would be another powerful illustration of the real world for calling async in sync, and I'll probably mention this somewhere.😃
ref: nodejs/node#45018

[SimenB]

Using a worker might work, but I think I'd rather avoid it 😅 It's not just a single back and forth, we'd need to load all of jest-snapshot within it, do diffing etc.

If we could preload prettier somehow and then have the APIs be sync it'd work. But I doubt that's something prettier would want

[liuxingbaoyu]

I just noticed that prettier seems to already have something like this, which is great!
https://github.com/prettier/prettier-synchronized

[SimenB]

Ah! If that becomes a thing I guess we could use that.

But dropping the runtime (albeit optional) dep on prettier would be preferable I think.

[sosukesuzuki]

Yes, maybe @prettier/sync would be useful for this purpose. However, if Jest will drop the Prettier usage for inline snapshots you can close this issue.

[github-actions]

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 30 days.

[fisker]

Please keep it open.

[fisker]

Can we try to run tests with [email protected] to see what's broken?

[SimenB]

Sure! Should be fine to just open a PR upgrading?

[SimenB]

Congrats on the release!

Should we use https://github.com/prettier/prettier-synchronized in Jest?

[uncleramsay]

Prettier v3 has dropped, and this appears to have broken snapshot testing in projects that upgrade. Is there any update on when we can expect to see support?

[mrazauskas]

Prettier v3 has dropped, and this appears to have broken snapshot testing in projects that upgrade.

This is tracked in #14305

[SimenB]

Done in #14566

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.