-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Admonitions on website #12495
Comments
Can I contribute for this issue? |
Yeah, any help appreciated! |
I'd search for "Note" in You should do just |
ok,I am on it:) |
@Biki-das you should had asked before opening a PR since I had claimed the issue beforehand,I was going though changes |
Sorry for that, i didn't saw it. |
i think we can create a task list,people who want to participate and contribute shuold create a issue link to a specified task first,and then pull request for this issue,one task should be linked only one issue at a time to prevent conflict |
I already worked on the main docs part, now someone can take Versioned docs to work on |
Since @Ash-KODES claimed the issue, I think it's fair for them to be able to contribute it if they want. It might make sense to split it up and do e.g. 5 files at a time, but that should be up to @Ash-KODES. |
yeah he has agreed to work on the versioned docs |
hey @Ash-KODES , you can work on the versioned docs part once i update the main docs correctly |
Ok then,I will work on versioned doc,,Np:) |
BTW, don't work on 27.0, 27.1, 27.2 or 27.4 - those will be deleted when Jest 28 is released soon. 27.5 will be renamed to 27.x. |
cc @Ash-KODES |
I will making different PRs for different files as mentioned in biki's PR |
This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 30 days. |
Ergh, not done yet 😅 |
Which one is left. |
Hi I believe I found and replaced every single usage of note, etc and replaced it with admonitions. My PR is here |
Hi! I would like to contribute if there's anything left I can help with @SimenB |
@paulreece are you still working on the changes? I checked your PR and it says the branch has some conflicts (I guess some parts have been updated after) |
@miguelfdezc @SimenB Thank you for pointing this out. The merge conflicts have now been resolved. All of the admonitions have been implemented and it's ready for merge. My PR is here |
Hi there, I'm [Syka Lerioti Elpida], a new contributor interested in helping out with this issue. I'm excited to learn more about testing and would love to get some guidance on how to proceed. Could you please provide me with more information on what specifically needs to be tested in this issue? Also, if you have any resources or tutorials on testing with Jest that would be really helpful. Thanks, and looking forward to contributing! Best, |
I would like to work on this issue |
Thank you all contributing to this issue. Thank you for the interest to help as well. I was looking through the files once again. Can’t spot any missing admonitions anymore. So this is done 🎉 🎉 🎉 |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
🚀 Feature Proposal
Our current docs are full of "Note:" and its ilk, sometimes as a quote (
>
), sometimes in italics etc.. We should instead use admonitions both since they look better, but also to have a consistent way of adding this type of info and it can differentiate between notes, tips etc..The text was updated successfully, but these errors were encountered: