refactor: use nullish coalescing operator on getProjectDisplayName (#…

…11410)
jestjs · May 16, 2021 · ecb0a9b · ecb0a9b
1 parent 04b7597
commit ecb0a9b
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 9 deletions.
diff --git a/packages/expect/src/utils.ts b/packages/expect/src/utils.ts
@@ -350,9 +350,7 @@ export const partition = <T>(
 export const isError = (value: unknown): value is Error => {
   switch (Object.prototype.toString.call(value)) {
     case '[object Error]':
-      return true;
     case '[object Exception]':
-      return true;
     case '[object DOMException]':
       return true;
     default:

diff --git a/packages/jest-core/src/getProjectDisplayName.ts b/packages/jest-core/src/getProjectDisplayName.ts
@@ -10,9 +10,5 @@ import type {Config} from '@jest/types';
 export default function getProjectDisplayName(
   projectConfig: Config.ProjectConfig,
 ): string | undefined {
-  const {displayName} = projectConfig;
-  if (!displayName) {
-    return undefined;
-  }
-  return displayName.name;
+  return projectConfig.displayName?.name || undefined;
 }
diff --git a/packages/jest-fake-timers/src/legacyFakeTimers.ts b/packages/jest-fake-timers/src/legacyFakeTimers.ts
@@ -526,9 +526,8 @@ export default class FakeTimers<TimerRef> {
 
     switch (timer.type) {
       case 'timeout':
-        const callback = timer.callback;
         this._timers.delete(timerHandle);
-        callback();
+        timer.callback();
         break;
 
       case 'interval':