review feedback

Author: phryneas

package.json

@@ -82,7 +82,7 @@
     "tempy": "^1.0.0",
     "ts-node": "^10.5.0",
     "tstyche": "^1.0.0-beta.9",
-    "typescript": "^5.2.2",
+    "typescript": "^5.0.4",
     "webpack": "^5.68.0",
     "webpack-node-externals": "^3.0.0",
     "which": "^4.0.0"

packages/jest-mock/src/__tests__/index.test.ts

@@ -10,6 +10,7 @@
 
 import * as util from 'util';
 import {type Context, createContext, runInContext, runInNewContext} from 'vm';
+import {onNodeVersions} from '@jest/test-utils';
 import {ModuleMocker, fn, mocked, spyOn} from '../';
 
 if (!Symbol.dispose) {
@@ -2441,25 +2442,27 @@ test('`fn` and `spyOn` do not throw', () => {
   }).not.toThrow();
 });
 
-describe('Explicit Resource Management', () => {
-  it('jest.fn state should be restored with the `using` keyword', () => {
-    const mock = jest.fn();
-    {
-      using inScope = mock.mockReturnValue(2);
-      expect(inScope()).toBe(2);
-      expect(mock()).toBe(2);
-    }
-    expect(mock()).not.toBe(2);
-  });
+onNodeVersions('>=18.0.0', () => {
+  describe('Explicit Resource Management', () => {
+    it('jest.fn state should be restored with the `using` keyword', () => {
+      const mock = jest.fn();
+      {
+        using inScope = mock.mockReturnValue(2);
+        expect(inScope()).toBe(2);
+        expect(mock()).toBe(2);
+      }
+      expect(mock()).not.toBe(2);
+    });
 
-  it('should be restored with the `using` keyword', () => {
-    {
-      using mockedLog = jest.spyOn(console, 'log');
-      expect(jest.isMockFunction(console.log)).toBeTruthy();
+    it('should be restored with the `using` keyword', () => {
+      {
+        using mockedLog = jest.spyOn(console, 'log');
+        expect(jest.isMockFunction(console.log)).toBeTruthy();
 
-      console.log('test');
-      expect(mockedLog).toHaveBeenCalled();
-    }
-    expect(jest.isMockFunction(console.log)).toBeFalsy();
+        console.log('test');
+        expect(mockedLog).toHaveBeenCalled();
+      }
+      expect(jest.isMockFunction(console.log)).toBeFalsy();
+    });
   });
 });

packages/jest-mock/tsconfig.json

@@ -2,7 +2,8 @@
   "extends": "../../tsconfig.json",
   "compilerOptions": {
     "rootDir": "src",
-    "outDir": "build"
+    "outDir": "build",
+    "lib": ["es2021", "ESNext.Disposable"]
   },
   "include": ["./src/**/*"],
   "exclude": ["./**/__tests__/**/*"],

tsconfig.json

@@ -8,7 +8,6 @@
     "declaration": true,
     "emitDeclarationOnly": true,
     "stripInternal": true,
-    "lib": ["es2021", "ESNext.Disposable"],
 
     "strict": true,