feat(expect-expect): support additionalTestBlockFunctions option
#850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
G-Rath
force-pushed
the
expect-expect-additional-test-blocks
branch
from
ae7c8b2
to
8e00541
Compare
|
(this is sort of on hold as I started looking at how we can implement this & the other general naming stuff as settings, then learnt that ESLint handles settings weirdly, which will change in the new config system). |
|
Going to merge because it's fine and a good thing for extending libraries, and who knows when I'm going to get back to the settings stuff. |
github-actions bot
pushed a commit
that referenced
this pull request
Oct 14, 2021
# [25.2.0](v25.1.0...v25.2.0) (2021-10-14) ### Features * **expect-expect:** support `additionalTestBlockFunctions` option ([#850](#850)) ([3b94c62](3b94c62))
|
🎉 This PR is included in version 25.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps with #534
Probably wants to be replaced with just
testBlockFunctionsat some point when we decide we want to supportsettings.Could be worth doing now - haven't decided 🤔