fix(no-done-callback): fix regression with it.each #708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
G-Rath
reviewed
Nov 12, 2020
G-Rath
reviewed
Nov 12, 2020
G-Rath
approved these changes
Nov 12, 2020
SimenB
reviewed
Nov 12, 2020
|
I mucked up my commit, so it needs to be reworded 🤦♂️ |
|
@G-Rath shall I amend that commit? I don't see what's wrong with the commit message though |
|
@k-yle yes please - it's the capital letter, changing it to |
Co-authored-by: Simen Bekkhus <[email protected]>
github-actions bot
pushed a commit
that referenced
this pull request
Nov 12, 2020
## [24.1.2](v24.1.1...v24.1.2) (2020-11-12) ### Bug Fixes * **no-done-callback:** fix regression with it.each ([#708](#708)) ([2f032f8](2f032f8))
|
🎉 This PR is included in version 24.1.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Mar 8, 2021
Closed
This was referenced Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #709
my recent PR #701 caused a false positive for
no-done-callbackwhen used with jest-each (sorry!)it.eachuses the first argument for options, and the second argument for the done callback.This PR fixes the bug and adds test cases for it.each