Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: get correct ruleName without specifying file extension #473

Merged
merged 2 commits into from
Nov 14, 2019

Conversation

Userbit
Copy link
Contributor

@Userbit Userbit commented Nov 14, 2019

In my own VSCode current version of forming url to a rule is incorrect.
Because of after transformation from TypeScript to JavaScript all **.ts file extensions become **.js and hence the below statement is invalid now:

const ruleName = basename(name, '.ts');

I suggest version that is independent on an extension.

@Userbit Userbit changed the title Get correct ruleName without specifying file extension fix: Get correct ruleName without specifying file extension Nov 14, 2019
src/rules/utils.ts Outdated Show resolved Hide resolved
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This is way cleaner

@SimenB SimenB changed the title fix: Get correct ruleName without specifying file extension fix: get correct ruleName without specifying file extension Nov 14, 2019
@SimenB SimenB merged commit f09203e into jest-community:master Nov 14, 2019
github-actions bot pushed a commit that referenced this pull request Nov 14, 2019
## [23.0.4](v23.0.3...v23.0.4) (2019-11-14)

### Bug Fixes

* get correct ruleName without specifying file extension ([#473](#473)) ([f09203e](f09203e))
@github-actions
Copy link

🎉 This PR is included in version 23.0.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants