Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo: possessive it's should be its #1264

Merged
merged 1 commit into from
Oct 14, 2022

Conversation

sirreal
Copy link
Contributor

@sirreal sirreal commented Oct 14, 2022

Fix a typo in valid-expect-in-promise that uses it's as a possessive instead of the correct its:

   17:5  error  This promise should either be returned or awaited to ensure the expects in it's chain are called  jest/valid-expect-in-promise

@sirreal sirreal changed the title Fix typo: possesive it's should be its Fix typo: possessive it's should be its Oct 14, 2022
@G-Rath G-Rath merged commit 4494ed2 into jest-community:main Oct 14, 2022
github-actions bot pushed a commit that referenced this pull request Oct 14, 2022
## [27.1.2](v27.1.1...v27.1.2) (2022-10-14)

### Bug Fixes

* **valid-expect-in-promise:** adjust grammer in rule message ([#1264](#1264)) ([4494ed2](4494ed2))
@nchevsky
Copy link

Sad that this fix ended up with a changelog entry of "valid-expect-in-promise: adjust grammer [sic] in rule message." 🥲

@G-Rath
Copy link
Collaborator

G-Rath commented Oct 14, 2022

ugh crap yeah sorry for some reason my dyslexia always messes that specific word for me without fail - I'll see if I can change it

@G-Rath
Copy link
Collaborator

G-Rath commented Oct 14, 2022

I've updated the GitHub release notes and opened #1265 updating the changelog.

I'd like to redo the commit but won't for obvious reasons.

@sirreal sirreal deleted the sirreal/fix-its-grammar branch October 15, 2022 07:09
@sirreal
Copy link
Contributor Author

sirreal commented Oct 17, 2022

No worries and thank you. I had several misspellings myself as I crafted this small PR 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants