Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New keys #713

Closed
axet opened this issue Mar 18, 2020 · 6 comments
Closed

New keys #713

axet opened this issue Mar 18, 2020 · 6 comments
Labels
enhancement New feature or request gocui usability

Comments

@axet
Copy link

axet commented Mar 18, 2020

Hello! I like your piece of software very much. But few keys seems not function enough. Two behavior a bit uncomfortable: 'tab' go forward, but shift 'tab' does not go backward. Keys 'left' and 'right' duplicate tab behavior for no reason, using page up and page down not very comfortable on every laptop.

I suggest few solutions:

  1. add 'shift+'tab hot key as opposite action to 'tab' what ever it hot keyed to.
  2. using page up and page down can be duplicated/replacement by ctrl+up and ctrl+down hotkeys?
  3. split similar behavior tab/shift+tab and left and right keys or replace it with scrolling source code window
@axet axet added the enhancement New feature or request label Mar 18, 2020
@jesseduffield
Copy link
Owner

  1. shift+tab is not possible on a terminal (or if it is it's not possible with termbox)
  2. I don't think ctrl+up and ctrl+down are supported either
  3. I'm not sure what you mean here

@axet
Copy link
Author

axet commented Mar 18, 2020

ok.

  1. duplicate behavior 'tab' and arrow 'right' can be do something else. like scrolling or something.

@axet axet closed this as completed Mar 18, 2020
@axet
Copy link
Author

axet commented Mar 18, 2020

@jesseduffield I'm not sure why are you saying 'back tab' is not possible. Simple test gives me a positive result:

# showkey -a
	 	  9 0011 0x09
^[[Z 	 27 0033 0x1b
 	 91 0133 0x5b
 	 90 0132 0x5a

@axet axet reopened this Mar 18, 2020
@jesseduffield
Copy link
Owner

I said it's likely not possible due to termbox, the underlying library used by gocui. There is a PR up in a fork of gocui, awesome-gocui/gocui#45, which switches to tcell. When that's done, we may be able to use shift+tab. I'll keep this issue open until that's resolved

@jesseduffield
Copy link
Owner

@axet the latest release has support for shift+tab now. I believe the other keys you mentioned can be handled via the config. Are we good to close this issue?

@axet
Copy link
Author

axet commented Apr 6, 2021

Thanks! Now it feels much more friendly!

@axet axet closed this as completed Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request gocui usability
Projects
None yet
Development

No branches or pull requests

2 participants