Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check-strings.sh should check all generated sources, not only lit-magic-strings.inc.h #5172

Open
ossy-szeged opened this issue Nov 21, 2024 · 0 comments
Labels
bug Undesired behaviour tools Related to the tooling scripts

Comments

@ossy-szeged
Copy link
Contributor

CI runs check-strings.sh to check if jerry-core/lit/lit-magic-strings.inc.h is up-to-date, but it doesn't check other generated sources. We could extend it to check them too.

gen-strings.py generates these sources:

  • jerry-core/ecma/base/ecma-error-messages.inc.h
  • jerry-core/lit/lit-magic-strings.inc.h
  • jerry-core/parser/js/parser-error-messages.inc.h

Maybe check-strings.sh can be extended to check all of them or check-strings.sh can be integrated to gen-strings.py

@ossy-szeged ossy-szeged added bug Undesired behaviour tools Related to the tooling scripts labels Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Undesired behaviour tools Related to the tooling scripts
Projects
None yet
Development

No branches or pull requests

1 participant