From 1d5a54d9061abde4021b663c5f578b56447f89da Mon Sep 17 00:00:00 2001 From: jerrydev0927 Date: Wed, 11 Jan 2023 17:26:46 +0000 Subject: [PATCH] [cleanup] remove feature flags warnAboutDefaultPropsOnFunctionComponents and warnAboutStringRefs (#25980) These feature flags are fully rolled out and easy to clean up. Let's remove them! DiffTrain build for [0fce6bb498357feb4465859912004b2e20fe7084](https://github.com/facebook/react/commit/0fce6bb498357feb4465859912004b2e20fe7084) [View git log for this commit](https://github.com/facebook/react/commits/0fce6bb498357feb4465859912004b2e20fe7084) --- compiled/facebook-www/REVISION | 2 +- compiled/facebook-www/REVISION_TRANSFORMS | 2 +- compiled/facebook-www/React-dev.classic.js | 2 +- compiled/facebook-www/React-dev.modern.js | 2 +- compiled/facebook-www/React-prod.classic.js | 2 +- compiled/facebook-www/React-prod.modern.js | 2 +- .../facebook-www/React-profiling.classic.js | 2 +- .../facebook-www/React-profiling.modern.js | 2 +- compiled/facebook-www/ReactART-dev.classic.js | 27 ++++++++----------- compiled/facebook-www/ReactART-dev.modern.js | 27 ++++++++----------- .../facebook-www/ReactART-prod.classic.js | 4 +-- compiled/facebook-www/ReactART-prod.modern.js | 4 +-- compiled/facebook-www/ReactDOM-dev.classic.js | 27 ++++++++----------- compiled/facebook-www/ReactDOM-dev.modern.js | 27 ++++++++----------- .../facebook-www/ReactDOM-prod.classic.js | 6 ++--- compiled/facebook-www/ReactDOM-prod.modern.js | 6 ++--- .../ReactDOM-profiling.classic.js | 6 ++--- .../facebook-www/ReactDOM-profiling.modern.js | 6 ++--- .../ReactDOMServer-dev.classic.js | 2 +- .../facebook-www/ReactDOMServer-dev.modern.js | 2 +- .../ReactDOMServer-prod.classic.js | 2 +- .../ReactDOMServer-prod.modern.js | 2 +- .../ReactDOMTesting-dev.classic.js | 27 ++++++++----------- .../ReactDOMTesting-dev.modern.js | 27 ++++++++----------- .../ReactDOMTesting-prod.classic.js | 6 ++--- .../ReactDOMTesting-prod.modern.js | 6 ++--- .../ReactTestRenderer-dev.classic.js | 27 ++++++++----------- .../ReactTestRenderer-dev.modern.js | 27 ++++++++----------- compiled/facebook-www/WARNINGS | 1 - 29 files changed, 122 insertions(+), 163 deletions(-) diff --git a/compiled/facebook-www/REVISION b/compiled/facebook-www/REVISION index a19e918c2c..c8b94ee116 100644 --- a/compiled/facebook-www/REVISION +++ b/compiled/facebook-www/REVISION @@ -1 +1 @@ -7002a6743ebb24ed55af8f626c89dd39460230fc +0fce6bb498357feb4465859912004b2e20fe7084 diff --git a/compiled/facebook-www/REVISION_TRANSFORMS b/compiled/facebook-www/REVISION_TRANSFORMS index a19e918c2c..c8b94ee116 100644 --- a/compiled/facebook-www/REVISION_TRANSFORMS +++ b/compiled/facebook-www/REVISION_TRANSFORMS @@ -1 +1 @@ -7002a6743ebb24ed55af8f626c89dd39460230fc +0fce6bb498357feb4465859912004b2e20fe7084 diff --git a/compiled/facebook-www/React-dev.classic.js b/compiled/facebook-www/React-dev.classic.js index d385897a97..835bd4101f 100644 --- a/compiled/facebook-www/React-dev.classic.js +++ b/compiled/facebook-www/React-dev.classic.js @@ -27,7 +27,7 @@ if ( } "use strict"; -var ReactVersion = "18.3.0-www-classic-7002a6743-20230110"; +var ReactVersion = "18.3.0-www-classic-0fce6bb49-20230111"; // ATTENTION // When adding new symbols to this file, diff --git a/compiled/facebook-www/React-dev.modern.js b/compiled/facebook-www/React-dev.modern.js index 74c5eee9c6..f9a30d5b93 100644 --- a/compiled/facebook-www/React-dev.modern.js +++ b/compiled/facebook-www/React-dev.modern.js @@ -27,7 +27,7 @@ if ( } "use strict"; -var ReactVersion = "18.3.0-www-modern-7002a6743-20230110"; +var ReactVersion = "18.3.0-www-modern-0fce6bb49-20230111"; // ATTENTION // When adding new symbols to this file, diff --git a/compiled/facebook-www/React-prod.classic.js b/compiled/facebook-www/React-prod.classic.js index 31cfc2264e..6fb13341bc 100644 --- a/compiled/facebook-www/React-prod.classic.js +++ b/compiled/facebook-www/React-prod.classic.js @@ -643,4 +643,4 @@ exports.useSyncExternalStore = function( ); }; exports.useTransition = useTransition; -exports.version = "18.3.0-www-classic-7002a6743-20230110"; +exports.version = "18.3.0-www-classic-0fce6bb49-20230111"; diff --git a/compiled/facebook-www/React-prod.modern.js b/compiled/facebook-www/React-prod.modern.js index faba275ce5..d5acc67127 100644 --- a/compiled/facebook-www/React-prod.modern.js +++ b/compiled/facebook-www/React-prod.modern.js @@ -635,4 +635,4 @@ exports.useSyncExternalStore = function( ); }; exports.useTransition = useTransition; -exports.version = "18.3.0-www-modern-7002a6743-20230110"; +exports.version = "18.3.0-www-modern-0fce6bb49-20230111"; diff --git a/compiled/facebook-www/React-profiling.classic.js b/compiled/facebook-www/React-profiling.classic.js index f9a1304035..56f22b6631 100644 --- a/compiled/facebook-www/React-profiling.classic.js +++ b/compiled/facebook-www/React-profiling.classic.js @@ -654,7 +654,7 @@ exports.useSyncExternalStore = function( ); }; exports.useTransition = useTransition; -exports.version = "18.3.0-www-classic-7002a6743-20230110"; +exports.version = "18.3.0-www-classic-0fce6bb49-20230111"; /* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */ if ( diff --git a/compiled/facebook-www/React-profiling.modern.js b/compiled/facebook-www/React-profiling.modern.js index 11c87170fd..a3258a6a18 100644 --- a/compiled/facebook-www/React-profiling.modern.js +++ b/compiled/facebook-www/React-profiling.modern.js @@ -646,7 +646,7 @@ exports.useSyncExternalStore = function( ); }; exports.useTransition = useTransition; -exports.version = "18.3.0-www-modern-7002a6743-20230110"; +exports.version = "18.3.0-www-modern-0fce6bb49-20230111"; /* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */ if ( diff --git a/compiled/facebook-www/ReactART-dev.classic.js b/compiled/facebook-www/ReactART-dev.classic.js index 8081e81420..017fe67791 100644 --- a/compiled/facebook-www/ReactART-dev.classic.js +++ b/compiled/facebook-www/ReactART-dev.classic.js @@ -69,7 +69,7 @@ function _assertThisInitialized(self) { return self; } -var ReactVersion = "18.3.0-www-classic-7002a6743-20230110"; +var ReactVersion = "18.3.0-www-classic-0fce6bb49-20230111"; var LegacyRoot = 0; var ConcurrentRoot = 1; @@ -201,7 +201,6 @@ var enableProfilerNestedUpdateScheduledHook = var createRootStrictEffectsByDefault = false; var enableSchedulingProfiler = dynamicFeatureFlags.enableSchedulingProfiler; // Note: we'll want to remove this when we to userland implementation. -var warnAboutStringRefs = true; var FunctionComponent = 0; var ClassComponent = 1; @@ -5558,10 +5557,8 @@ function coerceRef(returnFiber, current, element) { typeof mixedRef !== "object" ) { { - // TODO: Clean this up once we turn on the string ref warning for - // everyone, because the strict mode case will no longer be relevant if ( - (returnFiber.mode & StrictLegacyMode || warnAboutStringRefs) && // We warn in ReactElement.js if owner and self are equal for string refs + // We warn in ReactElement.js if owner and self are equal for string refs // because these cannot be automatically converted to an arrow function // using a codemod. Therefore, we don't have to warn about string refs again. !( @@ -5577,17 +5574,15 @@ function coerceRef(returnFiber, current, element) { getComponentNameFromFiber(returnFiber) || "Component"; if (!didWarnAboutStringRefs[componentName]) { - { - error( - 'Component "%s" contains the string ref "%s". Support for string refs ' + - "will be removed in a future major release. We recommend using " + - "useRef() or createRef() instead. " + - "Learn more about using refs safely here: " + - "https://reactjs.org/link/strict-mode-string-ref", - componentName, - mixedRef - ); - } + error( + 'Component "%s" contains the string ref "%s". Support for string refs ' + + "will be removed in a future major release. We recommend using " + + "useRef() or createRef() instead. " + + "Learn more about using refs safely here: " + + "https://reactjs.org/link/strict-mode-string-ref", + componentName, + mixedRef + ); didWarnAboutStringRefs[componentName] = true; } diff --git a/compiled/facebook-www/ReactART-dev.modern.js b/compiled/facebook-www/ReactART-dev.modern.js index 3b0db1e301..22301f04bb 100644 --- a/compiled/facebook-www/ReactART-dev.modern.js +++ b/compiled/facebook-www/ReactART-dev.modern.js @@ -69,7 +69,7 @@ function _assertThisInitialized(self) { return self; } -var ReactVersion = "18.3.0-www-modern-7002a6743-20230110"; +var ReactVersion = "18.3.0-www-modern-0fce6bb49-20230111"; var LegacyRoot = 0; var ConcurrentRoot = 1; @@ -201,7 +201,6 @@ var enableProfilerNestedUpdateScheduledHook = var createRootStrictEffectsByDefault = false; var enableSchedulingProfiler = dynamicFeatureFlags.enableSchedulingProfiler; // Note: we'll want to remove this when we to userland implementation. -var warnAboutStringRefs = true; var FunctionComponent = 0; var ClassComponent = 1; @@ -5320,10 +5319,8 @@ function coerceRef(returnFiber, current, element) { typeof mixedRef !== "object" ) { { - // TODO: Clean this up once we turn on the string ref warning for - // everyone, because the strict mode case will no longer be relevant if ( - (returnFiber.mode & StrictLegacyMode || warnAboutStringRefs) && // We warn in ReactElement.js if owner and self are equal for string refs + // We warn in ReactElement.js if owner and self are equal for string refs // because these cannot be automatically converted to an arrow function // using a codemod. Therefore, we don't have to warn about string refs again. !( @@ -5339,17 +5336,15 @@ function coerceRef(returnFiber, current, element) { getComponentNameFromFiber(returnFiber) || "Component"; if (!didWarnAboutStringRefs[componentName]) { - { - error( - 'Component "%s" contains the string ref "%s". Support for string refs ' + - "will be removed in a future major release. We recommend using " + - "useRef() or createRef() instead. " + - "Learn more about using refs safely here: " + - "https://reactjs.org/link/strict-mode-string-ref", - componentName, - mixedRef - ); - } + error( + 'Component "%s" contains the string ref "%s". Support for string refs ' + + "will be removed in a future major release. We recommend using " + + "useRef() or createRef() instead. " + + "Learn more about using refs safely here: " + + "https://reactjs.org/link/strict-mode-string-ref", + componentName, + mixedRef + ); didWarnAboutStringRefs[componentName] = true; } diff --git a/compiled/facebook-www/ReactART-prod.classic.js b/compiled/facebook-www/ReactART-prod.classic.js index 2158441dcd..b5adce829b 100644 --- a/compiled/facebook-www/ReactART-prod.classic.js +++ b/compiled/facebook-www/ReactART-prod.classic.js @@ -9804,7 +9804,7 @@ var slice = Array.prototype.slice, return null; }, bundleType: 0, - version: "18.3.0-www-classic-7002a6743-20230110", + version: "18.3.0-www-classic-0fce6bb49-20230111", rendererPackageName: "react-art" }; var internals$jscomp$inline_1318 = { @@ -9835,7 +9835,7 @@ var internals$jscomp$inline_1318 = { scheduleRoot: null, setRefreshHandler: null, getCurrentFiber: null, - reconcilerVersion: "18.3.0-next-7002a6743-20230110" + reconcilerVersion: "18.3.0-next-0fce6bb49-20230111" }; if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) { var hook$jscomp$inline_1319 = __REACT_DEVTOOLS_GLOBAL_HOOK__; diff --git a/compiled/facebook-www/ReactART-prod.modern.js b/compiled/facebook-www/ReactART-prod.modern.js index 69f6c9644a..79dec1b47b 100644 --- a/compiled/facebook-www/ReactART-prod.modern.js +++ b/compiled/facebook-www/ReactART-prod.modern.js @@ -9471,7 +9471,7 @@ var slice = Array.prototype.slice, return null; }, bundleType: 0, - version: "18.3.0-www-modern-7002a6743-20230110", + version: "18.3.0-www-modern-0fce6bb49-20230111", rendererPackageName: "react-art" }; var internals$jscomp$inline_1309 = { @@ -9502,7 +9502,7 @@ var internals$jscomp$inline_1309 = { scheduleRoot: null, setRefreshHandler: null, getCurrentFiber: null, - reconcilerVersion: "18.3.0-next-7002a6743-20230110" + reconcilerVersion: "18.3.0-next-0fce6bb49-20230111" }; if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) { var hook$jscomp$inline_1310 = __REACT_DEVTOOLS_GLOBAL_HOOK__; diff --git a/compiled/facebook-www/ReactDOM-dev.classic.js b/compiled/facebook-www/ReactDOM-dev.classic.js index 9f8db6903c..220aaa5361 100644 --- a/compiled/facebook-www/ReactDOM-dev.classic.js +++ b/compiled/facebook-www/ReactDOM-dev.classic.js @@ -72,7 +72,6 @@ var createRootStrictEffectsByDefault = false; var enableClientRenderFallbackOnTextMismatch = false; // Logs additional User Timing API marks for use with an experimental profiling tool. var enableSchedulingProfiler = dynamicFeatureFlags.enableSchedulingProfiler; // Note: we'll want to remove this when we to userland implementation. -var warnAboutStringRefs = true; var enableSuspenseCallback = true; var enableCustomElementPropertySupport = false; @@ -19789,10 +19788,8 @@ function coerceRef(returnFiber, current, element) { typeof mixedRef !== "object" ) { { - // TODO: Clean this up once we turn on the string ref warning for - // everyone, because the strict mode case will no longer be relevant if ( - (returnFiber.mode & StrictLegacyMode || warnAboutStringRefs) && // We warn in ReactElement.js if owner and self are equal for string refs + // We warn in ReactElement.js if owner and self are equal for string refs // because these cannot be automatically converted to an arrow function // using a codemod. Therefore, we don't have to warn about string refs again. !( @@ -19808,17 +19805,15 @@ function coerceRef(returnFiber, current, element) { getComponentNameFromFiber(returnFiber) || "Component"; if (!didWarnAboutStringRefs[componentName]) { - { - error( - 'Component "%s" contains the string ref "%s". Support for string refs ' + - "will be removed in a future major release. We recommend using " + - "useRef() or createRef() instead. " + - "Learn more about using refs safely here: " + - "https://reactjs.org/link/strict-mode-string-ref", - componentName, - mixedRef - ); - } + error( + 'Component "%s" contains the string ref "%s". Support for string refs ' + + "will be removed in a future major release. We recommend using " + + "useRef() or createRef() instead. " + + "Learn more about using refs safely here: " + + "https://reactjs.org/link/strict-mode-string-ref", + componentName, + mixedRef + ); didWarnAboutStringRefs[componentName] = true; } @@ -42695,7 +42690,7 @@ function createFiberRoot( return root; } -var ReactVersion = "18.3.0-www-classic-7002a6743-20230110"; +var ReactVersion = "18.3.0-www-classic-0fce6bb49-20230111"; function createPortal( children, diff --git a/compiled/facebook-www/ReactDOM-dev.modern.js b/compiled/facebook-www/ReactDOM-dev.modern.js index 2abb68ee8b..82ffc59d96 100644 --- a/compiled/facebook-www/ReactDOM-dev.modern.js +++ b/compiled/facebook-www/ReactDOM-dev.modern.js @@ -176,7 +176,6 @@ var createRootStrictEffectsByDefault = false; var enableClientRenderFallbackOnTextMismatch = false; // Logs additional User Timing API marks for use with an experimental profiling tool. var enableSchedulingProfiler = dynamicFeatureFlags.enableSchedulingProfiler; // Note: we'll want to remove this when we to userland implementation. -var warnAboutStringRefs = true; var enableSuspenseCallback = true; var enableCustomElementPropertySupport = true; @@ -19586,10 +19585,8 @@ function coerceRef(returnFiber, current, element) { typeof mixedRef !== "object" ) { { - // TODO: Clean this up once we turn on the string ref warning for - // everyone, because the strict mode case will no longer be relevant if ( - (returnFiber.mode & StrictLegacyMode || warnAboutStringRefs) && // We warn in ReactElement.js if owner and self are equal for string refs + // We warn in ReactElement.js if owner and self are equal for string refs // because these cannot be automatically converted to an arrow function // using a codemod. Therefore, we don't have to warn about string refs again. !( @@ -19605,17 +19602,15 @@ function coerceRef(returnFiber, current, element) { getComponentNameFromFiber(returnFiber) || "Component"; if (!didWarnAboutStringRefs[componentName]) { - { - error( - 'Component "%s" contains the string ref "%s". Support for string refs ' + - "will be removed in a future major release. We recommend using " + - "useRef() or createRef() instead. " + - "Learn more about using refs safely here: " + - "https://reactjs.org/link/strict-mode-string-ref", - componentName, - mixedRef - ); - } + error( + 'Component "%s" contains the string ref "%s". Support for string refs ' + + "will be removed in a future major release. We recommend using " + + "useRef() or createRef() instead. " + + "Learn more about using refs safely here: " + + "https://reactjs.org/link/strict-mode-string-ref", + componentName, + mixedRef + ); didWarnAboutStringRefs[componentName] = true; } @@ -42419,7 +42414,7 @@ function createFiberRoot( return root; } -var ReactVersion = "18.3.0-www-modern-7002a6743-20230110"; +var ReactVersion = "18.3.0-www-modern-0fce6bb49-20230111"; function createPortal( children, diff --git a/compiled/facebook-www/ReactDOM-prod.classic.js b/compiled/facebook-www/ReactDOM-prod.classic.js index 9c798826f2..8e322c3e23 100644 --- a/compiled/facebook-www/ReactDOM-prod.classic.js +++ b/compiled/facebook-www/ReactDOM-prod.classic.js @@ -15534,7 +15534,7 @@ Internals.Events = [ var devToolsConfig$jscomp$inline_1750 = { findFiberByHostInstance: getClosestInstanceFromNode, bundleType: 0, - version: "18.3.0-www-classic-7002a6743-20230110", + version: "18.3.0-www-classic-0fce6bb49-20230111", rendererPackageName: "react-dom" }; var internals$jscomp$inline_2134 = { @@ -15564,7 +15564,7 @@ var internals$jscomp$inline_2134 = { scheduleRoot: null, setRefreshHandler: null, getCurrentFiber: null, - reconcilerVersion: "18.3.0-next-7002a6743-20230110" + reconcilerVersion: "18.3.0-next-0fce6bb49-20230111" }; if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) { var hook$jscomp$inline_2135 = __REACT_DEVTOOLS_GLOBAL_HOOK__; @@ -15806,4 +15806,4 @@ exports.unstable_renderSubtreeIntoContainer = function( ); }; exports.unstable_runWithPriority = runWithPriority; -exports.version = "18.3.0-next-7002a6743-20230110"; +exports.version = "18.3.0-next-0fce6bb49-20230111"; diff --git a/compiled/facebook-www/ReactDOM-prod.modern.js b/compiled/facebook-www/ReactDOM-prod.modern.js index 66dc4c5a7c..7c253881ce 100644 --- a/compiled/facebook-www/ReactDOM-prod.modern.js +++ b/compiled/facebook-www/ReactDOM-prod.modern.js @@ -15095,7 +15095,7 @@ Internals.Events = [ var devToolsConfig$jscomp$inline_1718 = { findFiberByHostInstance: getClosestInstanceFromNode, bundleType: 0, - version: "18.3.0-www-modern-7002a6743-20230110", + version: "18.3.0-www-modern-0fce6bb49-20230111", rendererPackageName: "react-dom" }; var internals$jscomp$inline_2109 = { @@ -15126,7 +15126,7 @@ var internals$jscomp$inline_2109 = { scheduleRoot: null, setRefreshHandler: null, getCurrentFiber: null, - reconcilerVersion: "18.3.0-next-7002a6743-20230110" + reconcilerVersion: "18.3.0-next-0fce6bb49-20230111" }; if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) { var hook$jscomp$inline_2110 = __REACT_DEVTOOLS_GLOBAL_HOOK__; @@ -15314,4 +15314,4 @@ exports.unstable_flushControlled = function(fn) { } }; exports.unstable_runWithPriority = runWithPriority; -exports.version = "18.3.0-next-7002a6743-20230110"; +exports.version = "18.3.0-next-0fce6bb49-20230111"; diff --git a/compiled/facebook-www/ReactDOM-profiling.classic.js b/compiled/facebook-www/ReactDOM-profiling.classic.js index 57a18829dc..51b5aca9dd 100644 --- a/compiled/facebook-www/ReactDOM-profiling.classic.js +++ b/compiled/facebook-www/ReactDOM-profiling.classic.js @@ -16304,7 +16304,7 @@ Internals.Events = [ var devToolsConfig$jscomp$inline_1824 = { findFiberByHostInstance: getClosestInstanceFromNode, bundleType: 0, - version: "18.3.0-www-classic-7002a6743-20230110", + version: "18.3.0-www-classic-0fce6bb49-20230111", rendererPackageName: "react-dom" }; (function(internals) { @@ -16348,7 +16348,7 @@ var devToolsConfig$jscomp$inline_1824 = { scheduleRoot: null, setRefreshHandler: null, getCurrentFiber: null, - reconcilerVersion: "18.3.0-next-7002a6743-20230110" + reconcilerVersion: "18.3.0-next-0fce6bb49-20230111" }); assign(Internals, { ReactBrowserEventEmitter: { @@ -16577,7 +16577,7 @@ exports.unstable_renderSubtreeIntoContainer = function( ); }; exports.unstable_runWithPriority = runWithPriority; -exports.version = "18.3.0-next-7002a6743-20230110"; +exports.version = "18.3.0-next-0fce6bb49-20230111"; /* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */ if ( diff --git a/compiled/facebook-www/ReactDOM-profiling.modern.js b/compiled/facebook-www/ReactDOM-profiling.modern.js index 8d56736aa2..6c9c667cd5 100644 --- a/compiled/facebook-www/ReactDOM-profiling.modern.js +++ b/compiled/facebook-www/ReactDOM-profiling.modern.js @@ -15855,7 +15855,7 @@ Internals.Events = [ var devToolsConfig$jscomp$inline_1792 = { findFiberByHostInstance: getClosestInstanceFromNode, bundleType: 0, - version: "18.3.0-www-modern-7002a6743-20230110", + version: "18.3.0-www-modern-0fce6bb49-20230111", rendererPackageName: "react-dom" }; (function(internals) { @@ -15900,7 +15900,7 @@ var devToolsConfig$jscomp$inline_1792 = { scheduleRoot: null, setRefreshHandler: null, getCurrentFiber: null, - reconcilerVersion: "18.3.0-next-7002a6743-20230110" + reconcilerVersion: "18.3.0-next-0fce6bb49-20230111" }); exports.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED = Internals; exports.createPortal = function(children, container) { @@ -16075,7 +16075,7 @@ exports.unstable_flushControlled = function(fn) { } }; exports.unstable_runWithPriority = runWithPriority; -exports.version = "18.3.0-next-7002a6743-20230110"; +exports.version = "18.3.0-next-0fce6bb49-20230111"; /* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */ if ( diff --git a/compiled/facebook-www/ReactDOMServer-dev.classic.js b/compiled/facebook-www/ReactDOMServer-dev.classic.js index c0d4544795..233606300b 100644 --- a/compiled/facebook-www/ReactDOMServer-dev.classic.js +++ b/compiled/facebook-www/ReactDOMServer-dev.classic.js @@ -19,7 +19,7 @@ if (__DEV__) { var React = require("react"); var ReactDOM = require("react-dom"); -var ReactVersion = "18.3.0-www-classic-7002a6743-20230110"; +var ReactVersion = "18.3.0-www-classic-0fce6bb49-20230111"; // This refers to a WWW module. var warningWWW = require("warning"); diff --git a/compiled/facebook-www/ReactDOMServer-dev.modern.js b/compiled/facebook-www/ReactDOMServer-dev.modern.js index 4bb3661244..5f70c7ca81 100644 --- a/compiled/facebook-www/ReactDOMServer-dev.modern.js +++ b/compiled/facebook-www/ReactDOMServer-dev.modern.js @@ -19,7 +19,7 @@ if (__DEV__) { var React = require("react"); var ReactDOM = require("react-dom"); -var ReactVersion = "18.3.0-www-modern-7002a6743-20230110"; +var ReactVersion = "18.3.0-www-modern-0fce6bb49-20230111"; // This refers to a WWW module. var warningWWW = require("warning"); diff --git a/compiled/facebook-www/ReactDOMServer-prod.classic.js b/compiled/facebook-www/ReactDOMServer-prod.classic.js index 1da330c9ce..d801d39bed 100644 --- a/compiled/facebook-www/ReactDOMServer-prod.classic.js +++ b/compiled/facebook-www/ReactDOMServer-prod.classic.js @@ -3633,4 +3633,4 @@ exports.renderToString = function(children, options) { 'The server used "renderToString" which does not support Suspense. If you intended for this Suspense boundary to render the fallback content on the server consider throwing an Error somewhere within the Suspense boundary. If you intended to have the server wait for the suspended component please switch to "renderToReadableStream" which supports Suspense on the server' ); }; -exports.version = "18.3.0-www-classic-7002a6743-20230110"; +exports.version = "18.3.0-www-classic-0fce6bb49-20230111"; diff --git a/compiled/facebook-www/ReactDOMServer-prod.modern.js b/compiled/facebook-www/ReactDOMServer-prod.modern.js index 6b524f6b71..b2158433e3 100644 --- a/compiled/facebook-www/ReactDOMServer-prod.modern.js +++ b/compiled/facebook-www/ReactDOMServer-prod.modern.js @@ -3546,4 +3546,4 @@ exports.renderToString = function(children, options) { 'The server used "renderToString" which does not support Suspense. If you intended for this Suspense boundary to render the fallback content on the server consider throwing an Error somewhere within the Suspense boundary. If you intended to have the server wait for the suspended component please switch to "renderToReadableStream" which supports Suspense on the server' ); }; -exports.version = "18.3.0-www-modern-7002a6743-20230110"; +exports.version = "18.3.0-www-modern-0fce6bb49-20230111"; diff --git a/compiled/facebook-www/ReactDOMTesting-dev.classic.js b/compiled/facebook-www/ReactDOMTesting-dev.classic.js index dc847694e7..2b2a6ee56a 100644 --- a/compiled/facebook-www/ReactDOMTesting-dev.classic.js +++ b/compiled/facebook-www/ReactDOMTesting-dev.classic.js @@ -26,7 +26,6 @@ var enableSchedulingProfiler = false; var enableProfilerTimer = false; var disableCommentsAsDOMContainers = true; var enableSuspenseCallback = true; -var warnAboutStringRefs = true; var enableClientRenderFallbackOnTextMismatch = true; var createRootStrictEffectsByDefault = false; var enableLazyContextPropagation = false; @@ -11090,10 +11089,8 @@ function coerceRef(returnFiber, current, element) { typeof mixedRef !== "object" ) { { - // TODO: Clean this up once we turn on the string ref warning for - // everyone, because the strict mode case will no longer be relevant if ( - (returnFiber.mode & StrictLegacyMode || warnAboutStringRefs) && // We warn in ReactElement.js if owner and self are equal for string refs + // We warn in ReactElement.js if owner and self are equal for string refs // because these cannot be automatically converted to an arrow function // using a codemod. Therefore, we don't have to warn about string refs again. !( @@ -11109,17 +11106,15 @@ function coerceRef(returnFiber, current, element) { getComponentNameFromFiber(returnFiber) || "Component"; if (!didWarnAboutStringRefs[componentName]) { - { - error( - 'Component "%s" contains the string ref "%s". Support for string refs ' + - "will be removed in a future major release. We recommend using " + - "useRef() or createRef() instead. " + - "Learn more about using refs safely here: " + - "https://reactjs.org/link/strict-mode-string-ref", - componentName, - mixedRef - ); - } + error( + 'Component "%s" contains the string ref "%s". Support for string refs ' + + "will be removed in a future major release. We recommend using " + + "useRef() or createRef() instead. " + + "Learn more about using refs safely here: " + + "https://reactjs.org/link/strict-mode-string-ref", + componentName, + mixedRef + ); didWarnAboutStringRefs[componentName] = true; } @@ -31196,7 +31191,7 @@ function createFiberRoot( return root; } -var ReactVersion = "18.3.0-www-classic-7002a6743-20230110"; +var ReactVersion = "18.3.0-www-classic-0fce6bb49-20230111"; function createPortal( children, diff --git a/compiled/facebook-www/ReactDOMTesting-dev.modern.js b/compiled/facebook-www/ReactDOMTesting-dev.modern.js index 76db8eb6e7..1103c63bda 100644 --- a/compiled/facebook-www/ReactDOMTesting-dev.modern.js +++ b/compiled/facebook-www/ReactDOMTesting-dev.modern.js @@ -268,7 +268,6 @@ var enableSchedulingProfiler = false; var enableProfilerTimer = false; var disableCommentsAsDOMContainers = true; var enableSuspenseCallback = true; -var warnAboutStringRefs = true; var enableClientRenderFallbackOnTextMismatch = true; var createRootStrictEffectsByDefault = false; var enableLazyContextPropagation = false; @@ -18590,10 +18589,8 @@ function coerceRef(returnFiber, current, element) { typeof mixedRef !== "object" ) { { - // TODO: Clean this up once we turn on the string ref warning for - // everyone, because the strict mode case will no longer be relevant if ( - (returnFiber.mode & StrictLegacyMode || warnAboutStringRefs) && // We warn in ReactElement.js if owner and self are equal for string refs + // We warn in ReactElement.js if owner and self are equal for string refs // because these cannot be automatically converted to an arrow function // using a codemod. Therefore, we don't have to warn about string refs again. !( @@ -18609,17 +18606,15 @@ function coerceRef(returnFiber, current, element) { getComponentNameFromFiber(returnFiber) || "Component"; if (!didWarnAboutStringRefs[componentName]) { - { - error( - 'Component "%s" contains the string ref "%s". Support for string refs ' + - "will be removed in a future major release. We recommend using " + - "useRef() or createRef() instead. " + - "Learn more about using refs safely here: " + - "https://reactjs.org/link/strict-mode-string-ref", - componentName, - mixedRef - ); - } + error( + 'Component "%s" contains the string ref "%s". Support for string refs ' + + "will be removed in a future major release. We recommend using " + + "useRef() or createRef() instead. " + + "Learn more about using refs safely here: " + + "https://reactjs.org/link/strict-mode-string-ref", + componentName, + mixedRef + ); didWarnAboutStringRefs[componentName] = true; } @@ -38509,7 +38504,7 @@ function createFiberRoot( return root; } -var ReactVersion = "18.3.0-www-modern-7002a6743-20230110"; +var ReactVersion = "18.3.0-www-modern-0fce6bb49-20230111"; function createPortal( children, diff --git a/compiled/facebook-www/ReactDOMTesting-prod.classic.js b/compiled/facebook-www/ReactDOMTesting-prod.classic.js index ac48afb04c..9a4b093255 100644 --- a/compiled/facebook-www/ReactDOMTesting-prod.classic.js +++ b/compiled/facebook-www/ReactDOMTesting-prod.classic.js @@ -11328,7 +11328,7 @@ Internals.Events = [ var devToolsConfig$jscomp$inline_1518 = { findFiberByHostInstance: getClosestInstanceFromNode, bundleType: 0, - version: "18.3.0-www-classic-7002a6743-20230110", + version: "18.3.0-www-classic-0fce6bb49-20230111", rendererPackageName: "react-dom" }; var internals$jscomp$inline_2047 = { @@ -11358,7 +11358,7 @@ var internals$jscomp$inline_2047 = { scheduleRoot: null, setRefreshHandler: null, getCurrentFiber: null, - reconcilerVersion: "18.3.0-next-7002a6743-20230110" + reconcilerVersion: "18.3.0-next-0fce6bb49-20230111" }; if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) { var hook$jscomp$inline_2048 = __REACT_DEVTOOLS_GLOBAL_HOOK__; @@ -14847,4 +14847,4 @@ exports.unstable_renderSubtreeIntoContainer = function( ); }; exports.unstable_runWithPriority = runWithPriority; -exports.version = "18.3.0-next-7002a6743-20230110"; +exports.version = "18.3.0-next-0fce6bb49-20230111"; diff --git a/compiled/facebook-www/ReactDOMTesting-prod.modern.js b/compiled/facebook-www/ReactDOMTesting-prod.modern.js index e97d1c7f53..b57c8c3704 100644 --- a/compiled/facebook-www/ReactDOMTesting-prod.modern.js +++ b/compiled/facebook-www/ReactDOMTesting-prod.modern.js @@ -13967,7 +13967,7 @@ Internals.Events = [ var devToolsConfig$jscomp$inline_1673 = { findFiberByHostInstance: getClosestInstanceFromNode, bundleType: 0, - version: "18.3.0-www-modern-7002a6743-20230110", + version: "18.3.0-www-modern-0fce6bb49-20230111", rendererPackageName: "react-dom" }; var internals$jscomp$inline_2072 = { @@ -13998,7 +13998,7 @@ var internals$jscomp$inline_2072 = { scheduleRoot: null, setRefreshHandler: null, getCurrentFiber: null, - reconcilerVersion: "18.3.0-next-7002a6743-20230110" + reconcilerVersion: "18.3.0-next-0fce6bb49-20230111" }; if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) { var hook$jscomp$inline_2073 = __REACT_DEVTOOLS_GLOBAL_HOOK__; @@ -14321,4 +14321,4 @@ exports.unstable_flushControlled = function(fn) { } }; exports.unstable_runWithPriority = runWithPriority; -exports.version = "18.3.0-next-7002a6743-20230110"; +exports.version = "18.3.0-next-0fce6bb49-20230111"; diff --git a/compiled/facebook-www/ReactTestRenderer-dev.classic.js b/compiled/facebook-www/ReactTestRenderer-dev.classic.js index fbd4d9c58d..58e7e7ee88 100644 --- a/compiled/facebook-www/ReactTestRenderer-dev.classic.js +++ b/compiled/facebook-www/ReactTestRenderer-dev.classic.js @@ -137,7 +137,6 @@ var enableSchedulingProfiler = false; var enableProfilerTimer = true; var enableProfilerCommitHooks = true; var enableProfilerNestedUpdatePhase = true; -var warnAboutStringRefs = true; var createRootStrictEffectsByDefault = false; var enableLazyContextPropagation = false; var enableLegacyHidden = false; @@ -4524,10 +4523,8 @@ function coerceRef(returnFiber, current, element) { typeof mixedRef !== "object" ) { { - // TODO: Clean this up once we turn on the string ref warning for - // everyone, because the strict mode case will no longer be relevant if ( - (returnFiber.mode & StrictLegacyMode || warnAboutStringRefs) && // We warn in ReactElement.js if owner and self are equal for string refs + // We warn in ReactElement.js if owner and self are equal for string refs // because these cannot be automatically converted to an arrow function // using a codemod. Therefore, we don't have to warn about string refs again. !( @@ -4543,17 +4540,15 @@ function coerceRef(returnFiber, current, element) { getComponentNameFromFiber(returnFiber) || "Component"; if (!didWarnAboutStringRefs[componentName]) { - { - error( - 'Component "%s" contains the string ref "%s". Support for string refs ' + - "will be removed in a future major release. We recommend using " + - "useRef() or createRef() instead. " + - "Learn more about using refs safely here: " + - "https://reactjs.org/link/strict-mode-string-ref", - componentName, - mixedRef - ); - } + error( + 'Component "%s" contains the string ref "%s". Support for string refs ' + + "will be removed in a future major release. We recommend using " + + "useRef() or createRef() instead. " + + "Learn more about using refs safely here: " + + "https://reactjs.org/link/strict-mode-string-ref", + componentName, + mixedRef + ); didWarnAboutStringRefs[componentName] = true; } @@ -23892,7 +23887,7 @@ function createFiberRoot( return root; } -var ReactVersion = "18.3.0-www-classic-7002a6743-20230110"; +var ReactVersion = "18.3.0-www-classic-0fce6bb49-20230111"; // Might add PROFILE later. diff --git a/compiled/facebook-www/ReactTestRenderer-dev.modern.js b/compiled/facebook-www/ReactTestRenderer-dev.modern.js index 6009bd92e3..c05dbd0faf 100644 --- a/compiled/facebook-www/ReactTestRenderer-dev.modern.js +++ b/compiled/facebook-www/ReactTestRenderer-dev.modern.js @@ -137,7 +137,6 @@ var enableSchedulingProfiler = false; var enableProfilerTimer = true; var enableProfilerCommitHooks = true; var enableProfilerNestedUpdatePhase = true; -var warnAboutStringRefs = true; var createRootStrictEffectsByDefault = false; var enableLazyContextPropagation = false; var enableLegacyHidden = false; @@ -4524,10 +4523,8 @@ function coerceRef(returnFiber, current, element) { typeof mixedRef !== "object" ) { { - // TODO: Clean this up once we turn on the string ref warning for - // everyone, because the strict mode case will no longer be relevant if ( - (returnFiber.mode & StrictLegacyMode || warnAboutStringRefs) && // We warn in ReactElement.js if owner and self are equal for string refs + // We warn in ReactElement.js if owner and self are equal for string refs // because these cannot be automatically converted to an arrow function // using a codemod. Therefore, we don't have to warn about string refs again. !( @@ -4543,17 +4540,15 @@ function coerceRef(returnFiber, current, element) { getComponentNameFromFiber(returnFiber) || "Component"; if (!didWarnAboutStringRefs[componentName]) { - { - error( - 'Component "%s" contains the string ref "%s". Support for string refs ' + - "will be removed in a future major release. We recommend using " + - "useRef() or createRef() instead. " + - "Learn more about using refs safely here: " + - "https://reactjs.org/link/strict-mode-string-ref", - componentName, - mixedRef - ); - } + error( + 'Component "%s" contains the string ref "%s". Support for string refs ' + + "will be removed in a future major release. We recommend using " + + "useRef() or createRef() instead. " + + "Learn more about using refs safely here: " + + "https://reactjs.org/link/strict-mode-string-ref", + componentName, + mixedRef + ); didWarnAboutStringRefs[componentName] = true; } @@ -23892,7 +23887,7 @@ function createFiberRoot( return root; } -var ReactVersion = "18.3.0-www-modern-7002a6743-20230110"; +var ReactVersion = "18.3.0-www-modern-0fce6bb49-20230111"; // Might add PROFILE later. diff --git a/compiled/facebook-www/WARNINGS b/compiled/facebook-www/WARNINGS index 012c07cb46..5475969a6b 100644 --- a/compiled/facebook-www/WARNINGS +++ b/compiled/facebook-www/WARNINGS @@ -79,7 +79,6 @@ "A props object containing a \"key\" prop is being spread into JSX:\n let props = %s;\n <%s {...props} />\nReact keys must be passed directly to JSX without using spread:\n let props = %s;\n <%s key={someKey} {...props} />" "A script element was rendered with %s. If script element has children it must be a single string. Consider using dangerouslySetInnerHTML or passing a plain string as children." "A single row was passed to a . This is not useful since it needs multiple rows. Did you mean to pass multiple children or an array?" -"A string ref, \"%s\", has been found within a strict mode tree. String refs are a source of potential bugs and should be avoided. We recommend using useRef() or createRef() instead. Learn more about using refs safely here: https://reactjs.org/link/strict-mode-string-ref" "A suspended resource finished loading inside a test, but the event was not wrapped in act(...).\n\nWhen testing, code that resolves suspended data should be wrapped into act(...):\n\nact(() => {\n /* finish loading suspended data */\n});\n/* assert on the output */\n\nThis ensures that you're testing the behavior the user would see in the browser. Learn more at https://reactjs.org/link/wrap-tests-with-act" "A title element received a React element for children. In the browser title Elements can only have Text Nodes as children. If the children being rendered output more than a single text node in aggregate the browser will display markup and comments as text in the title and hydration will likely fail and fall back to client rendering" "A title element received a value that was not a string or number for children. In the browser title Elements can only have Text Nodes as children. If the children being rendered output more than a single text node in aggregate the browser will display markup and comments as text in the title and hydration will likely fail and fall back to client rendering"