Add URL to timeout error message

[mattdowle]

Hi,
curl usually works great and we all completely rely on it. Today I hit a rare problem that I tweeted about (here) in case someone else knows what the URL is that it is timing out on in this case. In general, it would be great if the error message including the URL that it was timing out on. For cases like this where all I see is a log file.

I'm trying to create a PR to curl to do this. I searched this repo for the string "timed" to find the error message but nothing came up. Then I searched this repo for "curl_fetch_memory" and I found lots of usage but, oddly, not where it is defined. I'll keep trying.
Could you give me some hints as to where I might modify the code to include the URL in the timeout error message?
Thanks, Matt

[krlmlr]

Perhaps in assert_status() ? Looks like the error message comes from libcurl.

curl/src/utils.c

Lines 44 to 49 in 1d9ba65

	void assert_status(CURLcode res, reference *ref){
	if(res == CURLE_OPERATION_TIMEDOUT)
	Rf_error("%s: %s", curl_easy_strerror(res), ref->errbuf);
	if(res != CURLE_OK)
	Rf_error("%s", strlen(ref->errbuf) ? ref->errbuf : curl_easy_strerror(res));
	}

[mattdowle]

Thanks for the tip, @krlmlr! I was able to trace it though from there and filed the PR.

[mattdowle]

I just saw the same timeout again. Is there anything else you'd like me to do in PR #191?

[jeroen]

Fix on CRAN now.

[mattdowle]

Great. Thanks, Jeroen!

[krlmlr]

Can we also include the hostname in generic error messages? Seeing travis build failures from pkgdown.

https://travis-ci.org/github/krlmlr/dm/jobs/677591111#L1151