Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Protect callback functions #157

Closed
jeroen opened this issue Jun 6, 2018 · 1 comment
Closed

Protect callback functions #157

jeroen opened this issue Jun 6, 2018 · 1 comment

Comments

@jeroen
Copy link
Owner

jeroen commented Jun 6, 2018

The progress callback and others are not explicitly protected right now and may get collected. Need to protect them like we do for the async callbacks.
@jeroen jeroen closed this as completed in 819379c Jun 7, 2018
@gaborcsardi
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jeroen @gaborcsardi