Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mount volumes on ProxyFleets #465

Closed
1 task done
TehNeon opened this issue Mar 16, 2024 · 3 comments · Fixed by #470
Closed
1 task done

Mount volumes on ProxyFleets #465

TehNeon opened this issue Mar 16, 2024 · 3 comments · Fixed by #470
Assignees
Labels
type:enhancement 🚀 New feature or request

Comments

@TehNeon
Copy link

TehNeon commented Mar 16, 2024

What happened?

I'm not sure whether to classify this as a bug or a feature request. ProxyFleets are unable to define volumes or volumeMounts in the podOverrides, where as the MinecraftServerFleet allows it to.

What components are involved in your issue?

Operator

Version

0.7.0

Kubernetes Version

1.27

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@TehNeon TehNeon added flag:triage ♻️ Waiting for triage type:bug 🐛 Something isn't working labels Mar 16, 2024
@jeremylvln
Copy link
Owner

Hi @TehNeon !

I was thinking it was not really needed for the proxies, but you are right, it's better for consistency to be able to do it on both. Would you mind share your usecase for my personal knowledge?

@jeremylvln jeremylvln self-assigned this Mar 18, 2024
@jeremylvln jeremylvln added type:enhancement 🚀 New feature or request and removed type:bug 🐛 Something isn't working flag:triage ♻️ Waiting for triage labels Mar 18, 2024
@jeremylvln jeremylvln changed the title ProxyFleet unable to mount Mount volumes on ProxyFleets Mar 18, 2024
@TehNeon
Copy link
Author

TehNeon commented Mar 18, 2024

Hi @TehNeon !

I was thinking it was not really needed for the proxies, but you are right, it's better for consistency to be able to do it on both. Would you mind share your usecase for my personal knowledge?

In my usecase, I'm trying to mount ConfigMaps which hold connection information for databases for some of my plugins.

I also may have found another issue with imagePullSecrets not getting applied correctly, but I still have some experimentation to do with that before potentially creating an issue for it.

Copy link

🎉 This issue has been resolved in version 0.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement 🚀 New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants