Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom annotations are not added to created ProxyFleet's Service #270

Closed
1 task done
jeremylvln opened this issue Dec 11, 2023 · 1 comment · Fixed by #273
Closed
1 task done

Custom annotations are not added to created ProxyFleet's Service #270

jeremylvln opened this issue Dec 11, 2023 · 1 comment · Fixed by #273
Assignees
@jeremylvln
Labels
type:bug 🐛 Something isn't working

Comments

@jeremylvln
Copy link
Owner

What happened?

When providing custom annotations in the ProxyFleet's Service, they are not added to the created Service. While it is supported in the CRD, it is actually not implemented (missing code here https://github.com/jeremylvln/Shulker/blob/main/packages/shulker-operator/src/reconcilers/proxy_fleet/service.rs#L52).

What components are involved in your issue?

Operator

Version

0.4.0

Kubernetes Version

1.26

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@jeremylvln jeremylvln added type:bug 🐛 Something isn't working flag:triage ♻️ Waiting for triage labels Dec 11, 2023
@jeremylvln jeremylvln self-assigned this Dec 11, 2023
@jeremylvln jeremylvln removed the flag:triage ♻️ Waiting for triage label Dec 11, 2023
@jeremylvln jeremylvln mentioned this issue Dec 12, 2023
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2024

🎉 This issue has been resolved in version 0.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeremylvln jeremylvln

Labels
type:bug 🐛 Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(shulker-operator): custom annotations not added to ProxyFleet ser… jeremylvln/Shulker
1 participant
@jeremylvln