From 0246c78c5b5e4346a4acfd578a2066d5b42ef7e8 Mon Sep 17 00:00:00 2001 From: Jens Holdgaard Pedersen Date: Sun, 28 Jun 2026 12:35:05 +0200 Subject: [PATCH] ci: run the RFC 0019 localstack S3 tests in the s3-integration job The s3-integration job's --exact list was pinned to the original four RFC 0013 tests, so the Store-migration localstack tests added since (querier/compactor/ audit Store listing/delete/CAS/audit-sink) compiled but never actually ran in CI. Add the six new ones to the list (still --exact, so the deferred rfc0013_8 todo! stub stays un-run). Also: fix a stale Writer::Poisoned message that still referenced a .parquet.tmp on disk (the writer went buffer-and-put in #294). Co-Authored-By: Claude Opus 4.8 --- .github/workflows/ci.yml | 10 ++++++++++ crates/ourios-parquet/src/writer.rs | 4 ++-- 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index a8090f139..790b463bf 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -95,6 +95,10 @@ jobs: with: toolchain: stable - uses: Swatinem/rust-cache@e18b497796c12c097a38f9edb9d0641fb99eee32 # v2 + # `--exact` with an explicit list (not bare `--ignored`) so the deferred + # `rfc0013_8_reader_forward_compat_over_store` `todo!()` stub stays + # un-run. The RFC 0019 Store-migration localstack tests join the list as + # they land (querier/compactor/audit + the Store listing/delete helpers). - run: > cargo test -p ourios-parquet --test rfc0013_object_store -- --ignored --exact @@ -102,6 +106,12 @@ jobs: rfc0013_3_atomic_publish_under_contention rfc0013_4_manifest_swap_via_conditional_put rfc0013_7_s3_compatible_endpoint_via_override + store_list_enumerates_keys_on_s3 + store_list_common_prefixes_rolls_up_on_s3 + store_list_with_sizes_reports_byte_lengths_on_s3 + store_delete_blocking_removes_on_s3 + compact_partition_consolidates_on_s3_via_cas + parquet_audit_sink_persists_to_s3 book: name: mdbook build diff --git a/crates/ourios-parquet/src/writer.rs b/crates/ourios-parquet/src/writer.rs index 7da3dcc56..ba5db7e54 100644 --- a/crates/ourios-parquet/src/writer.rs +++ b/crates/ourios-parquet/src/writer.rs @@ -553,8 +553,8 @@ impl fmt::Display for WriterError { f, "Writer is poisoned — a prior append_records failed with a Parquet error, \ leaving the buffer in an undefined state; close() refuses to publish to \ - avoid landing a partial / corrupted file (the .parquet.tmp is preserved \ - on disk for diagnosis)", + avoid landing a partial / corrupted file (the in-memory buffer is \ + discarded; nothing is put to the store)", ), } }